From 9b40e1a7ced9a8e2f9b6955369e44bafbdc38584 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 09:22:32 +1000 Subject: [PATCH 1/6] Update Roslyn to 5.11.0-1.26424.9 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3ed19ada-860a-4777-92b5-2a7815cc9f90 --- CHANGELOG.md | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++ package.json | 2 +- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f79d78c21..216b5c930 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,59 @@ - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) # 2.150.x +* Update Roslyn to 5.11.0-1.26424.9 (PR: [#](https://github.com/dotnet/vscode-csharp/pull/)) + * Re-land the sonic decl/impl split with fallback discovery parse reuse (PR: [#84844](https://github.com/dotnet/roslyn/pull/84844)) + * Dispose ISymUnmanagedReader correctly on .NET 10 (PR: [#84944](https://github.com/dotnet/roslyn/pull/84944)) + * Unsafe evolution: symbol display (PR: [#84706](https://github.com/dotnet/roslyn/pull/84706)) + * Avoid reparenting `Nullable.get_Value` to an error type (PR: [#84941](https://github.com/dotnet/roslyn/pull/84941)) + * Support loading cached project data from .lscache files (PR: [#84790](https://github.com/dotnet/roslyn/pull/84790)) + * Tolerate MSBuildWorkspace diagnostic warnings (PR: [#84971](https://github.com/dotnet/roslyn/pull/84971)) + * Fix rename conflict for source generated partial members (PR: [#84951](https://github.com/dotnet/roslyn/pull/84951)) + * Fix IDE0046 code fix throwing on top-level statements (PR: [#84966](https://github.com/dotnet/roslyn/pull/84966)) + * Avoid reordering by-ref locals (PR: [#84937](https://github.com/dotnet/roslyn/pull/84937)) + * Add opt-in ~/ asset-path expansion for Razor components (compiler) (PR: [#84796](https://github.com/dotnet/roslyn/pull/84796)) + * Improve recovery for repeated partial type modifiers (PR: [#84934](https://github.com/dotnet/roslyn/pull/84934)) + * Add HasPendingUpdates to HotReloadService.Updates to be used in dotnet-watch (PR: [#84891](https://github.com/dotnet/roslyn/pull/84891)) + * Caching compiler: support binary additional texts (PR: [#84916](https://github.com/dotnet/roslyn/pull/84916)) + * Fix/84847 source generated rename conflict (PR: [#84849](https://github.com/dotnet/roslyn/pull/84849)) + * Return MethodNotFound for unsupported LSP method dispatch (PR: [#84892](https://github.com/dotnet/roslyn/pull/84892)) + * Fix RestrictChildren incorrectly flagging valid child tags (PR: [#84870](https://github.com/dotnet/roslyn/pull/84870)) + * ShadowCopyAnalyzerPathResolver: Use cache to amortize cost of AV scans (PR: [#84765](https://github.com/dotnet/roslyn/pull/84765)) + * Revert "Use SQLite3MC (#84140)" and update SourceGear.Sqlite3 to 3.53.4 (PR: [#84692](https://github.com/dotnet/roslyn/pull/84692)) + * Add C# 15 language version (PR: [#84799](https://github.com/dotnet/roslyn/pull/84799)) + * Unsafe evolution: allow await in unsafe context (PR: [#84616](https://github.com/dotnet/roslyn/pull/84616)) + * Do not offer introduce parameter for incomplete calls (PR: [#84769](https://github.com/dotnet/roslyn/pull/84769)) + * Keep a fallback component's derived tag helpers during discovery (PR: [#84818](https://github.com/dotnet/roslyn/pull/84818)) + * Restore public GetCSharpDocument() and GeneratedCode for runtime compilation (PR: [#84813](https://github.com/dotnet/roslyn/pull/84813)) + * Share syntax trees across language server workspaces (PR: [#84758](https://github.com/dotnet/roslyn/pull/84758)) + * Add warnings for various unbound attributes in Razor (PR: [#84760](https://github.com/dotnet/roslyn/pull/84760)) + * Always pass C# formatting options to Razor functions (PR: [#84795](https://github.com/dotnet/roslyn/pull/84795)) + * Report CS8802 on every file with top-level statements (PR: [#83916](https://github.com/dotnet/roslyn/pull/83916)) + * Warn for empty outer tags when context switching from C# to markup (PR: [#84764](https://github.com/dotnet/roslyn/pull/84764)) + * Allow for better parallelization with brokered services (PR: [#82733](https://github.com/dotnet/roslyn/pull/82733)) + * Fix formatting error when Roslyn adds an extra blank line (PR: [#84751](https://github.com/dotnet/roslyn/pull/84751)) + * Clone the IR tree so we don't have to re-lower from syntax. (PR: [#84715](https://github.com/dotnet/roslyn/pull/84715)) + * Skip redundant discovery and declaration lowering when replaying a Razor document (PR: [#84698](https://github.com/dotnet/roslyn/pull/84698)) + * Consume split Razor declarations through pre-compilation source output (PR: [#84670](https://github.com/dotnet/roslyn/pull/84670)) + * Run Razor decl C# lowering before tag-helper discovery (classify-first component split) (PR: [#84605](https://github.com/dotnet/roslyn/pull/84605)) + * Split Razor components into decl/impl before tag-helper resolution (PR: [#84577](https://github.com/dotnet/roslyn/pull/84577)) + * Query impl and decl documents in Razor code lens and document symbols (PR: [#84586](https://github.com/dotnet/roslyn/pull/84586)) + * Move Razor to DocumentUri (PR: [#84370](https://github.com/dotnet/roslyn/pull/84370)) + * [Sonic] Completion support for multiple C# documents (PR: [#84222](https://github.com/dotnet/roslyn/pull/84222)) + * [Sonic] Debugging and breakpoint bits (PR: [#84166](https://github.com/dotnet/roslyn/pull/84166)) + * [Sonic] Support multiple C# documents in code actions (PR: [#84203](https://github.com/dotnet/roslyn/pull/84203)) + * [Sonic] Support multiple C# documents in auto insert (PR: [#84148](https://github.com/dotnet/roslyn/pull/84148)) + * [Sonic] Call hierarchy support for multiple C# documents (PR: [#84149](https://github.com/dotnet/roslyn/pull/84149)) + * [Sonic] Support multiple C# documents in Rename (PR: [#84134](https://github.com/dotnet/roslyn/pull/84134)) + * [Sonic] Support multiple C# documents in signature help (PR: [#84135](https://github.com/dotnet/roslyn/pull/84135)) + * [Sonic] Support multiple C# documents in formatting (PR: [#84097](https://github.com/dotnet/roslyn/pull/84097)) + * [Sonic] Inlay hints, folding ranges, and go to definition (PR: [#84102](https://github.com/dotnet/roslyn/pull/84102)) + * [Sonic] Support multiple C# documents in document highlight (PR: [#84025](https://github.com/dotnet/roslyn/pull/84025)) + * [Sonic] Support multiple C# documents in hover (PR: [#84031](https://github.com/dotnet/roslyn/pull/84031)) + * [Sonic] Support multiple C# generated documents in diagnostics (PR: [#83989](https://github.com/dotnet/roslyn/pull/83989)) + * [Sonic] Fix Semantic tokens (PR: [#83944](https://github.com/dotnet/roslyn/pull/83944)) + * Sonic 3.2: Activate the decl/impl split (PR: [#83887](https://github.com/dotnet/roslyn/pull/83887)) + * Sonic 3.1: Generate Decl Files (PR: [#83688](https://github.com/dotnet/roslyn/pull/83688)) # 2.149.x * Bump fast-uri from 3.1.4 to 3.1.5 (PR: [#9658](https://github.com/dotnet/vscode-csharp/pull/9658)) diff --git a/package.json b/package.json index 075024a31..eb0af21b4 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "workspace" ], "defaults": { - "roslyn": "5.11.0-1.26405.8", + "roslyn": "5.11.0-1.26424.9", "omniSharp": "1.39.14", "razorOmnisharp": "7.0.0-preview.23363.1", "xamlTools": "18.10.12014.341", From 3f094810d10b5a8f5a5cb0d7b537f28d1987bb5c Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 09:23:01 +1000 Subject: [PATCH 2/6] Update changelog with PR number Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3ed19ada-860a-4777-92b5-2a7815cc9f90 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 216b5c930..f4f1fb2e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) # 2.150.x -* Update Roslyn to 5.11.0-1.26424.9 (PR: [#](https://github.com/dotnet/vscode-csharp/pull/)) +* Update Roslyn to 5.11.0-1.26424.9 (PR: [#9701](https://github.com/dotnet/vscode-csharp/pull/9701)) * Re-land the sonic decl/impl split with fallback discovery parse reuse (PR: [#84844](https://github.com/dotnet/roslyn/pull/84844)) * Dispose ISymUnmanagedReader correctly on .NET 10 (PR: [#84944](https://github.com/dotnet/roslyn/pull/84944)) * Unsafe evolution: symbol display (PR: [#84706](https://github.com/dotnet/roslyn/pull/84706)) From d53d614fa91634e2e96d9b7149977fcb2895e3a5 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 09:25:55 +1000 Subject: [PATCH 3/6] Trim Roslyn changelog entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3ed19ada-860a-4777-92b5-2a7815cc9f90 --- CHANGELOG.md | 40 ---------------------------------------- 1 file changed, 40 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f4f1fb2e4..367a97254 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,58 +5,18 @@ # 2.150.x * Update Roslyn to 5.11.0-1.26424.9 (PR: [#9701](https://github.com/dotnet/vscode-csharp/pull/9701)) - * Re-land the sonic decl/impl split with fallback discovery parse reuse (PR: [#84844](https://github.com/dotnet/roslyn/pull/84844)) - * Dispose ISymUnmanagedReader correctly on .NET 10 (PR: [#84944](https://github.com/dotnet/roslyn/pull/84944)) - * Unsafe evolution: symbol display (PR: [#84706](https://github.com/dotnet/roslyn/pull/84706)) - * Avoid reparenting `Nullable.get_Value` to an error type (PR: [#84941](https://github.com/dotnet/roslyn/pull/84941)) * Support loading cached project data from .lscache files (PR: [#84790](https://github.com/dotnet/roslyn/pull/84790)) * Tolerate MSBuildWorkspace diagnostic warnings (PR: [#84971](https://github.com/dotnet/roslyn/pull/84971)) * Fix rename conflict for source generated partial members (PR: [#84951](https://github.com/dotnet/roslyn/pull/84951)) * Fix IDE0046 code fix throwing on top-level statements (PR: [#84966](https://github.com/dotnet/roslyn/pull/84966)) - * Avoid reordering by-ref locals (PR: [#84937](https://github.com/dotnet/roslyn/pull/84937)) - * Add opt-in ~/ asset-path expansion for Razor components (compiler) (PR: [#84796](https://github.com/dotnet/roslyn/pull/84796)) - * Improve recovery for repeated partial type modifiers (PR: [#84934](https://github.com/dotnet/roslyn/pull/84934)) * Add HasPendingUpdates to HotReloadService.Updates to be used in dotnet-watch (PR: [#84891](https://github.com/dotnet/roslyn/pull/84891)) - * Caching compiler: support binary additional texts (PR: [#84916](https://github.com/dotnet/roslyn/pull/84916)) * Fix/84847 source generated rename conflict (PR: [#84849](https://github.com/dotnet/roslyn/pull/84849)) * Return MethodNotFound for unsupported LSP method dispatch (PR: [#84892](https://github.com/dotnet/roslyn/pull/84892)) - * Fix RestrictChildren incorrectly flagging valid child tags (PR: [#84870](https://github.com/dotnet/roslyn/pull/84870)) * ShadowCopyAnalyzerPathResolver: Use cache to amortize cost of AV scans (PR: [#84765](https://github.com/dotnet/roslyn/pull/84765)) - * Revert "Use SQLite3MC (#84140)" and update SourceGear.Sqlite3 to 3.53.4 (PR: [#84692](https://github.com/dotnet/roslyn/pull/84692)) - * Add C# 15 language version (PR: [#84799](https://github.com/dotnet/roslyn/pull/84799)) - * Unsafe evolution: allow await in unsafe context (PR: [#84616](https://github.com/dotnet/roslyn/pull/84616)) * Do not offer introduce parameter for incomplete calls (PR: [#84769](https://github.com/dotnet/roslyn/pull/84769)) - * Keep a fallback component's derived tag helpers during discovery (PR: [#84818](https://github.com/dotnet/roslyn/pull/84818)) - * Restore public GetCSharpDocument() and GeneratedCode for runtime compilation (PR: [#84813](https://github.com/dotnet/roslyn/pull/84813)) * Share syntax trees across language server workspaces (PR: [#84758](https://github.com/dotnet/roslyn/pull/84758)) - * Add warnings for various unbound attributes in Razor (PR: [#84760](https://github.com/dotnet/roslyn/pull/84760)) * Always pass C# formatting options to Razor functions (PR: [#84795](https://github.com/dotnet/roslyn/pull/84795)) - * Report CS8802 on every file with top-level statements (PR: [#83916](https://github.com/dotnet/roslyn/pull/83916)) - * Warn for empty outer tags when context switching from C# to markup (PR: [#84764](https://github.com/dotnet/roslyn/pull/84764)) - * Allow for better parallelization with brokered services (PR: [#82733](https://github.com/dotnet/roslyn/pull/82733)) * Fix formatting error when Roslyn adds an extra blank line (PR: [#84751](https://github.com/dotnet/roslyn/pull/84751)) - * Clone the IR tree so we don't have to re-lower from syntax. (PR: [#84715](https://github.com/dotnet/roslyn/pull/84715)) - * Skip redundant discovery and declaration lowering when replaying a Razor document (PR: [#84698](https://github.com/dotnet/roslyn/pull/84698)) - * Consume split Razor declarations through pre-compilation source output (PR: [#84670](https://github.com/dotnet/roslyn/pull/84670)) - * Run Razor decl C# lowering before tag-helper discovery (classify-first component split) (PR: [#84605](https://github.com/dotnet/roslyn/pull/84605)) - * Split Razor components into decl/impl before tag-helper resolution (PR: [#84577](https://github.com/dotnet/roslyn/pull/84577)) - * Query impl and decl documents in Razor code lens and document symbols (PR: [#84586](https://github.com/dotnet/roslyn/pull/84586)) - * Move Razor to DocumentUri (PR: [#84370](https://github.com/dotnet/roslyn/pull/84370)) - * [Sonic] Completion support for multiple C# documents (PR: [#84222](https://github.com/dotnet/roslyn/pull/84222)) - * [Sonic] Debugging and breakpoint bits (PR: [#84166](https://github.com/dotnet/roslyn/pull/84166)) - * [Sonic] Support multiple C# documents in code actions (PR: [#84203](https://github.com/dotnet/roslyn/pull/84203)) - * [Sonic] Support multiple C# documents in auto insert (PR: [#84148](https://github.com/dotnet/roslyn/pull/84148)) - * [Sonic] Call hierarchy support for multiple C# documents (PR: [#84149](https://github.com/dotnet/roslyn/pull/84149)) - * [Sonic] Support multiple C# documents in Rename (PR: [#84134](https://github.com/dotnet/roslyn/pull/84134)) - * [Sonic] Support multiple C# documents in signature help (PR: [#84135](https://github.com/dotnet/roslyn/pull/84135)) - * [Sonic] Support multiple C# documents in formatting (PR: [#84097](https://github.com/dotnet/roslyn/pull/84097)) - * [Sonic] Inlay hints, folding ranges, and go to definition (PR: [#84102](https://github.com/dotnet/roslyn/pull/84102)) - * [Sonic] Support multiple C# documents in document highlight (PR: [#84025](https://github.com/dotnet/roslyn/pull/84025)) - * [Sonic] Support multiple C# documents in hover (PR: [#84031](https://github.com/dotnet/roslyn/pull/84031)) - * [Sonic] Support multiple C# generated documents in diagnostics (PR: [#83989](https://github.com/dotnet/roslyn/pull/83989)) - * [Sonic] Fix Semantic tokens (PR: [#83944](https://github.com/dotnet/roslyn/pull/83944)) - * Sonic 3.2: Activate the decl/impl split (PR: [#83887](https://github.com/dotnet/roslyn/pull/83887)) - * Sonic 3.1: Generate Decl Files (PR: [#83688](https://github.com/dotnet/roslyn/pull/83688)) # 2.149.x * Bump fast-uri from 3.1.4 to 3.1.5 (PR: [#9658](https://github.com/dotnet/vscode-csharp/pull/9658)) From 215f7fd100eecd679bd06fd1833022284d3a0775 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 09:26:57 +1000 Subject: [PATCH 4/6] Apply suggestion from @davidwengier --- CHANGELOG.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 367a97254..32abf71fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,15 +6,10 @@ # 2.150.x * Update Roslyn to 5.11.0-1.26424.9 (PR: [#9701](https://github.com/dotnet/vscode-csharp/pull/9701)) * Support loading cached project data from .lscache files (PR: [#84790](https://github.com/dotnet/roslyn/pull/84790)) - * Tolerate MSBuildWorkspace diagnostic warnings (PR: [#84971](https://github.com/dotnet/roslyn/pull/84971)) * Fix rename conflict for source generated partial members (PR: [#84951](https://github.com/dotnet/roslyn/pull/84951)) * Fix IDE0046 code fix throwing on top-level statements (PR: [#84966](https://github.com/dotnet/roslyn/pull/84966)) - * Add HasPendingUpdates to HotReloadService.Updates to be used in dotnet-watch (PR: [#84891](https://github.com/dotnet/roslyn/pull/84891)) * Fix/84847 source generated rename conflict (PR: [#84849](https://github.com/dotnet/roslyn/pull/84849)) - * Return MethodNotFound for unsupported LSP method dispatch (PR: [#84892](https://github.com/dotnet/roslyn/pull/84892)) - * ShadowCopyAnalyzerPathResolver: Use cache to amortize cost of AV scans (PR: [#84765](https://github.com/dotnet/roslyn/pull/84765)) * Do not offer introduce parameter for incomplete calls (PR: [#84769](https://github.com/dotnet/roslyn/pull/84769)) - * Share syntax trees across language server workspaces (PR: [#84758](https://github.com/dotnet/roslyn/pull/84758)) * Always pass C# formatting options to Razor functions (PR: [#84795](https://github.com/dotnet/roslyn/pull/84795)) * Fix formatting error when Roslyn adds an extra blank line (PR: [#84751](https://github.com/dotnet/roslyn/pull/84751)) From ff9345cc2e7e443493035c2e91d8d0e6d3e01c20 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 09:28:24 +1000 Subject: [PATCH 5/6] Improve Roslyn changelog filtering guidance Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3ed19ada-860a-4777-92b5-2a7815cc9f90 --- .github/skills/update-roslyn-version/SKILL.md | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/skills/update-roslyn-version/SKILL.md b/.github/skills/update-roslyn-version/SKILL.md index 0689eed34..0aa6d55f7 100644 --- a/.github/skills/update-roslyn-version/SKILL.md +++ b/.github/skills/update-roslyn-version/SKILL.md @@ -176,21 +176,29 @@ Note: Leave the PR number blank initially (just `[#]`) - it will be updated afte ### Step 8: Filter Changelog Entries -Review the changelog entries in `CHANGELOG.md` and remove any PRs that obviously don't affect VS Code. Remove entries that are: +Treat the changelog as a concise list of user-facing VS Code editor and language server changes, not a list of all production changes in Roslyn. Review the PR title and, when its impact is ambiguous, its changed files or description. + +Remove entries that are: - **Infrastructure/Build changes**: CI/CD pipelines, build scripts, Azure DevOps configurations - **Visual Studio-only changes**: Features or fixes specific to Visual Studio IDE (not VS Code) - **Test-only changes**: Test infrastructure, test fixes that don't affect production code - **Internal tooling**: Changes to internal tools not used by the language server - **Documentation-only**: README updates, internal docs (unless they document user-facing features) +- **Compiler-only changes**: Language implementation, parsing, lowering, emit, code generation, compiler APIs, or compiler performance changes without direct editor or language server impact +- **Razor compiler internals**: Razor parsing, lowering, code generation, or compiler architecture changes that do not directly change the VS Code editing experience +- **Internal refactoring and dependencies**: Architectural refactors, implementation details, package updates, or internal performance work unless they have a clear user-visible effect in VS Code Keep entries that are: - Language server protocol (LSP) changes -- Code analysis/diagnostics improvements +- Code analysis or diagnostics improvements visible in the editor - Completion, navigation, refactoring features -- Performance improvements +- Performance improvements specifically affecting editor or language server responsiveness - Bug fixes that affect language server behavior -- API changes that could affect VS Code extension +- Razor changes that directly affect editing features such as formatting, completion, navigation, or code actions +- API changes consumed by the VS Code extension or language server + +When uncertain, omit the entry from `CHANGELOG.md`; the complete unfiltered list remains available in the pull request description. ### Step 9: Commit and Push From 94ac84b484f08abc474a3a820283e5433cd6c129 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Tue, 25 Aug 2026 10:26:31 +1000 Subject: [PATCH 6/6] Make Razor rename test edit order independent --- test/razor/razorIntegrationTests/rename.integration.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/razor/razorIntegrationTests/rename.integration.test.ts b/test/razor/razorIntegrationTests/rename.integration.test.ts index cfcf51c37..4af28f2bd 100644 --- a/test/razor/razorIntegrationTests/rename.integration.test.ts +++ b/test/razor/razorIntegrationTests/rename.integration.test.ts @@ -64,6 +64,9 @@ describe(`Razor Rename ${testAssetWorkspace.description}`, function () { expect(uri.path).toStrictEqual(activeDocument.path); expect(edits.length).toBe(3); + // Rename edits can come from multiple generated documents, so their order is not guaranteed. + edits.sort((a, b) => a.range.start.compareTo(b.range.start)); + const edit1 = edits[0]; expect(edit1.range).toStrictEqual( new vscode.Range(new vscode.Position(6, 33), new vscode.Position(6, 45))