Repository navigation
Issue 77 scss refactor - #88
Conversation
…m associated views. TODO: comment SCSS, replace all colors with variables.
|
WIP - need to comment SCSS still. Functionality is complete. |
… in variables, all hard coded colors removed from SCSS and variables referenced.
|
One thing that is needed is a loading spinner or some sort of indicator for the UI until the application is initialized. Currently, there is a grey screen as UI.JS is loaded. This is a subsecond load, but in the event that something fails, the user will be staring at a grey screen. Some design thought needs to be put into how we are going to display the loading screen and relay any startup sequence failures. I believe this should be addressed in #42 |
| test: /\.(eot|svg|ttf|woff|woff2)$/, | ||
| loader: 'file-loader?name=/fonts/[name].[ext]', | ||
| }, | ||
| /* { |
There was a problem hiding this comment.
If you're going to comment this out and it's meant to remain this way, please make sure to add a comment about why you're commenting it out.
There was a problem hiding this comment.
Sorry, you're right, that should be removed.
rfay
left a comment
rfay
left a comment
There was a problem hiding this comment.
This seems like a perfectly fine piece of work to me. It seems we'll want to move a few more things into variables as time goes on, but this seems like a good path. Thanks!
The Problem/Issue/Bug:
We were using a global css file vs modular SCSS
How this PR Solves The Problem:
overrides.css (former global stylesheet) was broken down to separate SCSS files, and each component calls it's associated style. For example, all styles for the project cards are in cards.scss, and is called by the javascript component (site-cards.js)
Manual Testing Instructions:
make clean && make npmstartwill clear node_modules, reinstall via npm install, run webpack to bundle assets, and finally launch the development version of the app via electron.Project should remain unchanged visually as no CSS rules were added or removed in the conversion process.
Related Issue Link(s):
#77