Skip to content

ADD: disableRemotePlayback attribute for HTML5 videos#18619

Merged
trueadm merged 2 commits into
react:masterfrom
tombrowndev:master
Apr 16, 2020
Merged

ADD: disableRemotePlayback attribute for HTML5 videos#18619
trueadm merged 2 commits into
react:masterfrom
tombrowndev:master

Conversation

@tombrowndev

@tombrowndev tombrowndev commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

This is a fix for issue #18618.

Given this has a wide browser support, I think this should be available.

@facebook-github-bot

facebook-github-bot commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Hi @tombrowndev!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@tombrowndev tombrowndev mentioned this pull request Apr 15, 2020
Closed
@codesandbox-ci

codesandbox-ci Bot commented Apr 15, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit adaff1a:

Sandbox Source
aged-sunset-eyexz Configuration

@tombrowndev tombrowndev reopened this Apr 15, 2020
@tombrowndev

tombrowndev commented Apr 15, 2020

Copy link
Copy Markdown
Contributor Author

I have now signed the CLA, do I need to remake this PR or will it recognise it?

@sizebot

sizebot commented Apr 15, 2020 •
edited
Loading

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against adaff1a

@sizebot

sizebot commented Apr 15, 2020 •
edited
Loading

Copy link
Copy Markdown

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against adaff1a

@facebook-github-bot

facebook-github-bot commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

trueadm
trueadm approved these changes Apr 16, 2020
View reviewed changes

@trueadm trueadm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@trueadm trueadm merged commit 5f6b75d into react:master Apr 16, 2020
This was referenced Mar 6, 2021
Closed
Closed
Open
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Closed
This was referenced Mar 14, 2021
Merged
Closed
Closed
This was referenced Mar 15, 2021
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Closed
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 20, 2024
Open
Open
This was referenced Oct 1, 2024
Closed
Open
mrizwanashiq pushed a commit to mrizwanashiq/react that referenced this pull request Jun 25, 2026
@tombrowndev @tombrown-ibm
ADD: disableRemotePlayback attribute for HTML5 videos (react#18619)
e708242 
* Add support for disableremoteplayback

* Order attributes alphabetically

Co-authored-by: Tom Brown <Thomas.Brown-CIC-UK@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@trueadm trueadm trueadm approved these changes
@umanglpatel umanglpatel umanglpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tombrowndev @facebook-github-bot @sizebot @trueadm @umanglpatel @tombrown-ibm