You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4a94311
Browse filesBrowse the repository at this point in the historyBrowse files
ref(aws-serverless): Use @sentry/conventions (#21597)
Sources span attribute keys from `@sentry/conventions/attributes`
instead of the locally vendored `./semconv` constants (and direct
`@opentelemetry/semantic-conventions` imports), for the attributes that
have a `@sentry/conventions` equivalent. No functional change — the
resolved attribute key strings are identical.
Attributes with no `@sentry/conventions` equivalent stay vendored
locally: AWS-specific keys (`aws.dynamodb.*`, `aws.sns.topic.arn`, …),
`faas.execution`, `faas.id`, `gen_ai.request.stop_sequences`, and
`rpc.system`.
This supersedes #21491, which was opened before `develop` substantially
refactored these vendored files (the `SemconvStability` dual-semconv
handling was removed). Rather than rebase through those conflicts, the
migration is re-authored on top of current `develop`. Unlike the
previous PR, this does **not** add a `paths` override to the shared
`packages/typescript/tsconfig.json` — `@sentry/conventions/attributes`
resolves via the package's own `exports` map.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* @note If one of the predefined values applies, but specific system uses a different name it's **RECOMMENDED** to document it in the semantic conventions for specific GenAI system and use system-specific name in the instrumentation. If a different name is not documented, instrumentation libraries **SHOULD** use applicable predefined value.
335
-
*
336
-
* @experimental This attribute is experimental and is subject to breaking changes in minor releases of `@opentelemetry/semantic-conventions`.
* The number of messages sent, received, or processed in the scope of the batching operation.
445
-
*
446
-
* @example 0
447
-
* @example 1
448
-
* @example 2
449
-
*
450
-
* @note Instrumentations **SHOULD NOT** set `messaging.batch.message_count` on spans that operate with a single message. When a messaging client library supports both batch and single-message API for the same operation, instrumentations **SHOULD** use `messaging.batch.message_count` for batching APIs and **SHOULD NOT** use it for single-message APIs.
451
-
*
452
-
* @experimental This attribute is experimental and is subject to breaking changes in minor releases of `@opentelemetry/semantic-conventions`.
* The messaging system as identified by the client instrumentation.
501
-
*
502
-
* @note The actual messaging system may differ from the one known by the client. For example, when using Kafka client libraries to communicate with Azure Event Hubs, the `messaging.system` is set to `kafka` based on the instrumentation's best knowledge.
503
-
*
504
-
* @experimental This attribute is experimental and is subject to breaking changes in minor releases of `@opentelemetry/semantic-conventions`.
* The name of the (logical) method being called, must be equal to the $method part in the span name.
510
-
*
511
-
* @example "exampleMethod"
512
-
*
513
-
* @note This is the logical name of the method from the RPC interface perspective, which can be different from the name of any implementing method/function. The `code.function.name` attribute may be used to store the latter (e.g., method actually executing the call on the server side, RPC client stub method on the client side).
514
-
*
515
-
* @experimental This attribute is experimental and is subject to breaking changes in minor releases of `@opentelemetry/semantic-conventions`.
516
-
*/
517
-
exportconstATTR_RPC_METHOD='rpc.method'asconst;
518
-
519
-
/**
520
-
* The full (logical) name of the service being called, including its package name, if applicable.
521
-
*
522
-
* @example "myservice.EchoService"
523
-
*
524
-
* @note This is the logical name of the service from the RPC interface perspective, which can be different from the name of any implementing class. The `code.namespace` attribute may be used to store the latter (despite the attribute name, it may include a class name; e.g., class with method actually executing the call on the server side, RPC client stub class on the client side).
525
-
*
526
-
* @experimental This attribute is experimental and is subject to breaking changes in minor releases of `@opentelemetry/semantic-conventions`.
527
-
*/
528
-
exportconstATTR_RPC_SERVICE='rpc.service'asconst;
529
-
530
317
/**
531
318
* A string identifying the remoting system. See below for a list of well-known identifiers.
0 commit comments