You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b3dd1d6
Browse filesBrowse the repository at this point in the historyBrowse files
test(cloudflare): Port the request handler suites to span streaming
Removes the `traceLifecycle: 'static'` pin from `suites/hono-sdk`,
`suites/double-instrumentation` and `suites/public-api/metrics/server-address`,
and rewrites the Hono transaction assertions to span v2.
`double-instrumentation` and the metrics suite assert on an error event and on a
metric envelope, so only the pin goes. `double-instrumentation` swaps its
`ignore('transaction')` for `ignore('span')`, which is the envelope the
`http.server` span now races the error event with.
The Hono routes are parametrized patterns, so their segment names survive
streaming unchanged. What does change is the status: span v2 carries the coarse
`error` on the span and the specific `internal_error` in the
`sentry.status.message` attribute.
`suites/basic` keeps the static pin as the package's guard for the static trace
lifecycle. It is the smallest suite that still covers a plain worker fetch.
`suites/request-handler/subpath` also stays pinned, but for a different reason:
`wrapRequestHandler` from `@sentry/cloudflare/request` still sends a transaction
envelope with the pin removed, even with `traceLifecycle: 'stream'` passed
explicitly and with `cacheClient: false`. The client it builds does carry the
`SpanStreaming` integration, so the span reaches the isolation scope's client but
`getClient()` in `_onSpanEnded` does not see a streaming client. That is an SDK
question rather than a test one, so the suite is left as it was and gets its own
issue.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments