Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import datasetsimports aiohttp just to referenceaiohttp.ClientErrorin the two retryexceptclauses infile_utils.py. That's about 50 ms of a ~470 ms import (python -X importtime -c "import datasets"), and nothing else imports aiohttp at that point.This looks the error type up when the
exceptclause runs, and only if aiohttp is already insys.modules: if it was never imported, it can't have raised. This follows the"x" in sys.moduleschecks used elsewhere in the library.Tests:
test_import_datasets_does_not_import_aiohttpfails on main and passes here;test_read_with_retries_retries_aiohttp_client_errorchecks aiohttp errors are still retried.tests/test_file_utils.pypasses andmake qualityis clean.AI assistance (Claude) was used in preparing this change; I reviewed it and ran the tests locally.