Conversation
…ctor to use for types
Owner
|
There's a reason I don't provide a default .ctor, though, which is that it needs a |
Author
|
Could fix that by using a private class variable SearchTerm initialised from default ctor. |
Owner
|
Initialized to what? What would be the default expectation of the type of search if someone writes: var query = new SearchQuery ();This is why I don't want a public .ctor. It makes the API confusing. |
Author
|
Alright valid point. You could initialize with SearchTerm.All and provide a public ctor overload with SearchTerm param. |
jstedfast
added a commit
that referenced
this pull request
Apr 30, 2016
…e/deserialize via JSON. Fixes issue #331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when deserializing mailkit searchquery (in use with hangfire job) the error "Newtonsoft.Json.JsonSerializationException cannot find default public constructor" is thrown.
Adding the default constructor fixes the deserialization error.