Repository navigation
Conversation
Preserve idle debouncing while bounding scheduled deferral with a monotonic clock. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. (5 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: bounding quota snapshot persistence deferral during sustained updates. It matches the changes in src/codex/quota.ts and src/providers/account… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title clearly and concisely describes the main change: bounding quota snapshot persistence deferral during sustained updates. It matches the changes in src/codex/quota.ts and src/providers/account-quota-disk.ts.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 4 files. (5 skipped: 5 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
✅ Deterministic PR hygiene checks passed. |
|
No description provided. |
Summary
The Codex and provider quota snapshot writers restart their 250 ms debounce timer on every update. With continuous observations arriving more often than that, disk persistence can be postponed indefinitely. The live in-memory value advances while restart recovery continues to see an old snapshot.
Preserve the 250 ms idle debounce and add a 1,000 ms maximum scheduled deferral from the first pending update, matching the existing quota reset ledger policy. Use the monotonic clock so wall-clock corrections cannot extend the window. The callback snapshots the latest accepted state; each completed, failed or cancelled write resets its timing state. Clearing one Codex account preserves the deadline for the remaining rows, and clearing all accounts cancels it.
The snapshot formats, ownership/identity checks, quota calculations, hydration expiry and atomic replacement behavior remain unchanged. The bound is on timer scheduling: event-loop delays and filesystem failures remain best-effort. This is a pre-existing persistence issue verified on the pinned Bun 1.4.3 test runtime and production Bun 1.4.4, not a new Bun 1.4.4 regression.
Add real-filesystem regressions under controlled timers for idle bursts, consecutive busy windows, latest provider row/Kiro-verdict callbacks, account removal, cancellation/home reset and recovery after a failed write. Add the focused quota-snapshot authority document and its manifest/index entries. Existing broad ownership documents are already at their size limits; no file-size limit was raised.
Verification
Base: fork
devatc4d4bb2da2162e23c314befafc5ec104292902a0. Linux x64; official Bun binaries. Repository tests used the normal preload/shared lock in the host PID namespace.Real-clock reproduction
A separate probe runs the exported Codex quota writer in an isolated temporary home, first persists value
1, then sends 25 updates at 100 ms intervals. Both probes use the same script except for the imported baseline/fixed source module. Actual snapshot files are read during the run.This confirms the issue outside fake timers on Bun 1.4.4. The committed regressions cover both writers and deterministically assert the latest disk contents across consecutive busy windows. Against unchanged source they produced 15 passes / 3 expected failures across two files.
Commands and results
The first, third and fourth commands use the pinned Bun 1.4.3 wrapper; the second directly uses official Bun 1.4.4.
bun scripts/test.ts tests/codex-integration/codex-quota-persistence.test.ts tests/providers/provider-account-quota-persistence.test.ts tests/codex-integration/main-quota-provenance.test.tsbun test tests/codex-integration/codex-quota-persistence.test.ts tests/providers/provider-account-quota-persistence.test.ts— Bun 1.4.4bun scripts/test.ts --changed=dev quota kirobun scripts/test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.tsbun run typecheck;bun run structure:check;bun run privacy:scan;bun scripts/file-size-ratchet.ts;git diff --cached --checkFor the scoped import-connected quota/Kiro selection,
HTTP_PROXY,HTTPS_PROXY,ALL_PROXYand their lowercase variants were removed from the test environment;NO_PROXYremained intact. Production proxy policies and fixtures are unchanged.The full repository suite was not rerun under the documented concurrent-worktree/resource exception. Validation covers the two writers, connected quota/Kiro paths, main-identity provenance, layout guards and static gates. Native Windows/macOS execution, live provider behavior and broader exact-head CI remain separate. No public setting, DTO or workflow changed; the internal persistence contract is documented in
structure/quota-snapshots.md.Independent review by a separate agent found no material issue. That review also probed a real 1 ms producer for 2.2 seconds against the staged provider writer: 1,995 observations on Bun 1.4.3 and 2,003 on Bun 1.4.4. The first snapshot was visible while updates continued at approximately 1,004 / 1,006 ms, and the final callback value was retained after the producer stopped. This checks minimum-cadence scheduling in addition to the 100 ms Codex probe; it does not turn the best-effort timer into a hard real-time guarantee. This is agent review, not maintainer approval or hosted bot review.
Checklist
Co-authored-by: luvs01 27862058+luvs01@users.noreply.github.com
Summary by CodeRabbit