Skip to content

[Feature] Random text, number, person name or email - #256

Merged
dmitry-zaitsev merged 6 commits into
mobile-dev-inc:mainfrom
ttpho:feature/input-text-random
Oct 5, 2022
Merged

[Feature] Random text, number, person name or email #256
dmitry-zaitsev merged 6 commits into
mobile-dev-inc:mainfrom
ttpho:feature/input-text-random

Conversation

@ttpho

@ttpho ttpho commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Proposed Changes

added command input random:

  • inputRandomText
  • inputRandomNumber
  • inputRandomEmail
  • inputRandomPersonName
- inputRandomNumber: # This command will add text as number with length is 2, 10 <= number <= 99
      length: 2
- inputRandomText: # This command will add random text with a length is 3, as Abc, ads, asd, .... 
      inputType: "text"
      length: 3
- inputRandomEmail # This command will add a random email address as liam_smith_asds@gmail.com
- inputRandomPersonName  # This command will add a random person's name as Liam Smith

Testing

MaestroCommandSerializationTest.kt

IntegrationTest.kt

Issues Fixed

Comment thread maestro-test/src/test/resources/051_text_random.yaml Outdated
Comment thread maestro-orchestra-models/src/main/java/maestro/orchestra/util/InputTextRandom.kt Outdated

@dmitry-zaitsev dmitry-zaitsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It mostly looks good with few minor comments on the API

@ttpho

ttpho commented Oct 4, 2022

Copy link
Copy Markdown
Contributor Author

@dmitry-zaitsev Thank you for your review. I will refactore my source code.

@ttpho

ttpho commented Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

@dmitry-zaitsev Please help me review this PR again when you are free. Sorry for any mistakes. English is not my native language.

@dmitry-zaitsev dmitry-zaitsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@dmitry-zaitsev

Copy link
Copy Markdown
Contributor

@ttpho could you please share your Twitter and/or LinkedIn profile so that we can give you a proper shout out?

@dmitry-zaitsev
dmitry-zaitsev merged commit 559db50 into mobile-dev-inc:main Oct 5, 2022
@ttpho

ttpho commented Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

@dmitry-zaitsev Thank you for your review and approval 🙇
My LinkedIn profile is tpho

I wrote an article about Maestro. I hope more people use maestro

https://ttpho.github.io/2022-09-25-maestro/

rikur pushed a commit to rikur/maestro that referenced this pull request Jul 10, 2026
* implemented input text random

* Merge branch 'main' into feature/input-text-random

* refactor source code and update test case

* Update IntegrationTest.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants