Skip to content

lookup: remove sqlite3 - #1124

Merged
BethGriggs merged 10 commits into
nodejs:mainfrom
MikeMcC399:remove/sqlite3
Sep 29, 2026
Merged

BethGriggs merged 10 commits into
nodejs:mainfrom
MikeMcC399:remove/sqlite3

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

sqlite3 is deprecated. It cannot therefore fulfil the Hard Requirements:

The maintainers of the module remain responsive when there are problems

Item Status
npm package https://www.npmjs.com/package/sqlite3
npm status
last published 6.0.1 Mar 3, 2026
repo location https://github.com/TryGhost/node-sqlite3
repo status archived on Jul 1, 2026
lookup maintainer(s) koistya
Node.js npm macos ubuntu windows
22.23.1 10.9.8 pass pass pass
24.19.0 11.17.0 pass pass pass
26.7.0 11.19.0 fail fail fail
26.7.0 12.0.2 - fail -

Change

Remove sqlite3 from lib/lookup.json

Checklist
  • npm test passes
  • contribution guidelines followed
    here

cc: @koistya

@codecov-commenter

codecov-commenter commented Aug 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (126096c) to head (a2dd50a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 10, 2026 14:06
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 closed this Sep 11, 2026
@MikeMcC399 MikeMcC399 reopened this Sep 28, 2026
@MikeMcC399

Copy link
Copy Markdown
Contributor Author

@sxa - This one as well

@BethGriggs
BethGriggs merged commit c1db338 into nodejs:main Sep 29, 2026
11 checks passed
@MikeMcC399
MikeMcC399 deleted the remove/sqlite3 branch September 29, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants