Skip to content

Added Issue and PR Templates#1364

Merged
PeterDaveHello merged 1 commit into
nodejs:masterfrom
sudiptog81:dev-sudiptog81
Nov 11, 2020
Merged

Added Issue and PR Templates#1364
PeterDaveHello merged 1 commit into
nodejs:masterfrom
sudiptog81:dev-sudiptog81

Conversation

@sudiptog81

@sudiptog81 sudiptog81 commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Added ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md in .github.

Closes #1214.
Closes #1346.

@PeterDaveHello PeterDaveHello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterDaveHello

Copy link
Copy Markdown
Member

@sudiptog81 thanks for the contribution!

The current issue template in this pull request looks like a bug report template, do you think you can also add a feature request template, as not all the issues are bug related?

I think we can do it by putting them in the folder:
https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/manually-creating-a-single-issue-template-for-your-repository

@sudiptog81

Copy link
Copy Markdown
Contributor Author

Sure. I will address the comments in my next commit.

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking pretty good, just some minor suggestions that could also come later

Comment thread .github/ISSUE_TEMPLATE/1-bug-report.md Outdated
Comment thread .github/ISSUE_TEMPLATE/config.yml
Comment thread .github/ISSUE_TEMPLATE/config.yml
@sudiptog81 sudiptog81 requested a review from nschonni October 11, 2020 02:07
@PeterDaveHello

Copy link
Copy Markdown
Member

Nice work @sudiptog81 👍 Please give us a while to review it 😄

@PeterDaveHello PeterDaveHello requested a review from a team October 12, 2020 02:17

@PeterDaveHello PeterDaveHello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PeterDaveHello PeterDaveHello requested a review from a team November 9, 2020 08:38
@PeterDaveHello

Copy link
Copy Markdown
Member

Ask for one more approval from @nodejs/docker 😃

@PeterDaveHello

Copy link
Copy Markdown
Member

@sudiptog81 would you squash these commits and rebase your branch base on the latest master branch? I can also help you do it if you want.

@sudiptog81

Copy link
Copy Markdown
Contributor Author

@sudiptog81 would you squash these commits and rebase your branch base on the latest master branch? I can also help you do it if you want.

I'll do that as soon as able. Thanks for the approval!

@PeterDaveHello PeterDaveHello merged commit 554638e into nodejs:master Nov 11, 2020
@PeterDaveHello

Copy link
Copy Markdown
Member

Let's get it merged, and we'll see if there is anything we can improve in the usage.

@PeterDaveHello

Copy link
Copy Markdown
Member

Awesome

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GitHub Pull Request Templates Create GitHub Issue Templates

3 participants