Skip to content

Commit 7a2f322

Browse files
codebytereaduh95
authored andcommitted
build: fix quiet default for make builds
The Makefile documents quiet output unless V=1 and sets `V ?= 0`, but it forwards `V=$(V)` to the gyp-generated makefile, which tests `ifdef V`. "0" is a non-empty value there, so every make build has printed the full compiler command lines regardless. Default V to empty so the sub-make takes its quiet_ rules; `make V=1` and V=1 in the environment stay verbose, and the ninja and cpplint checks already compare against 1. Refs: #26740 Refs: nodejs/build#4419 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65826 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 6262e0b commit 7a2f322

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ BUILD_RELEASE_FLAGS ?= $(BUILD_DOWNLOAD_FLAGS) $(BUILD_INTL_FLAGS)
9696

9797
# Default to quiet/pretty builds.
9898
# To do verbose builds, run `make V=1` or set the V environment variable.
99-
V ?= 0
99+
V ?=
100100

101101
# Use -e to double check in case it's a broken link
102102
available-node = \

0 commit comments

Comments
 (0)