Skip to content

doc: replace _WG_ with _team_#22183

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:terminology
Closed

doc: replace _WG_ with _team_#22183
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:terminology

Conversation

@Trott

@Trott Trott commented Aug 7, 2018

Copy link
Copy Markdown
Member

AFAICT, there is no N-API Working Group. There is an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

Checklist

@Trott Trott added the fast-track PRs that do not need to wait for 72 hours to land. label Aug 7, 2018
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 7, 2018
@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Re-running lite job now that #22184 has landed.

@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

@vsemozhetbyt

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)
@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Hmmm...it appears that the lite-pipeline job may not rebase against master. So it's not picking up the recently-landed fix. Guess I'll rebase and force push and see if that helps things along...

@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

@nodejs/tsc @nodejs/n-api

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs#22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Landed in fcb46a4

@Trott Trott closed this Aug 8, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: #22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the terminology branch January 13, 2022 22:50
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs/node#22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants