lib: add 'pid' prefix in internal/util#3878
Conversation
|
LGTM |
|
won't this break some tests? |
|
I would imagine for any tests checking for the old string. @JungMinu did you run the tests locally with your changes? |
|
LGTM if CI is green Update: ... which, it's not ... sadly. @JungMinu , can you please take a look at the failing tests and update those here as well. Thank you! |
|
Yea, |
|
@JungMinu ... I'll take a look in the morning. Could you post the failure that you're seeing, however? |
|
Looking at the test message I'm guessing this is because you haven't updated the test to use your new prefix instead of the hardcoded one when comparing the two warnings. |
|
@jasnell I found the solution, Thanks :) |
There was a problem hiding this comment.
are we sure that the child process' pid will always be current+1 ?
There was a problem hiding this comment.
@targos would you recommend alternative to fix this? :)
There was a problem hiding this comment.
I would use a RegExp to match stderr
There was a problem hiding this comment.
Agree, something like assert(/util\.debug is deprecated/.test(stderr)) could suffice, but you could also use the RegExp constructor to match the whole line.
There was a problem hiding this comment.
@targos @silverwind Yup, I will update soon, Thanks :)
|
@jasnell @silverwind @cjihrig Thanks, finished with |
There was a problem hiding this comment.
Sorry, just looking at this again. Couldn't you just assert(/util\.debug is deprecated.../.test(stderr));
|
@cjihrig Sure, updated :) |
There was a problem hiding this comment.
Heh. I put ... in my original comment to avoid typing out the entire message. Sorry for the mix up.
Funny, this should actually still work, since . matches a single character. I don't think it's necessary to try to match the entire deprecation message verbatim. Drop the ... and this LGTM. Sorry again.
This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) lib: add 'pid' prefix in `internal/util`
|
@cjihrig No problem, finished :) |
|
LGTM pending CI: |
|
Seeing one possibly flaky test error in CI (see https://ci.nodejs.org/job/node-test-commit-linux/1271/nodes=fedora21/console). Assuming that's an unrelated error, LGTM |
|
LGTM |
|
LGTM (still) |
|
will get this landed! |
This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) PR-URL: #3878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in d01eb68 |
|
@jasnell Yes, I will finish that PR tomorrow :) |
|
thank you @JungMinu ! |
rvagg
added
the
semver-major
|
I believe this should be semver-major like the other changes to error messages. Tagging it as such will ensure it won't slip in to v5.x (like it just did while I was working through the list). Please speak up if you disagree or if you think I'm reading this wrong. |
|
Works for me
|
|
@rvagg Sounds good to me :) |
9 participants
This PR improves
prefixinutilthat we've agreed on #3833(separate PR for javascript in
lib, and the original PR will be updated to move the printing function to C++ insrcdirectly)