test: added test for https-agent-getname#6762
Closed
suryagh wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
/cc @timotheeg idk, but just in case if this can be leveraged for the test you seems to be working to reproduce #6687 |
Contributor
|
CI: https://ci.nodejs.org/job/node-test-commit/3343/ FreeBSD failure is unrelated |
|
|
||
| require('../common'); | ||
| var assert = require('assert'); | ||
| var https = require('https'); |
Member
|
couple of minor nits but otherwise LGTM |
Member
|
@nodejs/http |
Contributor
|
same. LGTM once nits are addressed. |
Contributor
|
LGTM. @suryagh just a heads up, GitHub doesn't notify anyone when you update a PR, so it's helpful if you leave a comment. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
Member
|
CI had a few build bot and flaky failures... just to be safe, running again: https://ci.nodejs.org/job/node-test-pull-request/2680/ |
jasnell
pushed a commit
that referenced
this pull request
May 17, 2016
PR-URL: #6762 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Member
|
Landed in 377eb22 |
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
PR-URL: #6762 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #6762 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Added tests for
https.Agent.getName()