From 491666c47f9dfda943f81c2181bc1003292f5a02 Mon Sep 17 00:00:00 2001 From: Michiel de Jong Date: Fri, 25 Sep 2026 08:46:09 +0200 Subject: [PATCH] Split the Installation release line so "from" gets a catalog entry feat/plugin-debug still nested the "from " fragment inside the "Pinned to" paragraph. wuchale gives that nested message an index but no catalog entry, so the Release section rendered "[i18n-404:NNNN]". Port the two-paragraph shape from develop (#1654) to InstallationPage and InstallationReviewDialog, and commit the catalogs vite settles on for it. Co-Authored-By: Claude Opus 5.5 --- .../Plugins/InstallationReviewDialog.tsx | 10 +++---- browser/data-browser/src/locales/de.po | 22 +++++++++++---- browser/data-browser/src/locales/en.po | 22 +++++++++++---- browser/data-browser/src/locales/es.po | 22 +++++++++++---- browser/data-browser/src/locales/fr.po | 22 +++++++++++---- .../views/Installation/InstallationPage.tsx | 28 ++++++++++--------- 6 files changed, 83 insertions(+), 43 deletions(-) diff --git a/browser/data-browser/src/chunks/Plugins/InstallationReviewDialog.tsx b/browser/data-browser/src/chunks/Plugins/InstallationReviewDialog.tsx index 418932133a..649c953e8f 100644 --- a/browser/data-browser/src/chunks/Plugins/InstallationReviewDialog.tsx +++ b/browser/data-browser/src/chunks/Plugins/InstallationReviewDialog.tsx @@ -169,12 +169,9 @@ export const InstallationReviewDialog: React.FC< Release Pinned to {pending.release.id} - {pending.release.url !== pending.release.id && ( - <> -
- from {pending.release.url} - - )} +
+ @@ -228,4 +225,5 @@ const Identity = styled.p` overflow-wrap: anywhere; font-size: 0.8rem; color: ${p => p.theme.colors.textLight}; + margin: 0; `; diff --git a/browser/data-browser/src/locales/de.po b/browser/data-browser/src/locales/de.po index 6175af1b39..1a1fa371fc 100644 --- a/browser/data-browser/src/locales/de.po +++ b/browser/data-browser/src/locales/de.po @@ -8858,12 +8858,8 @@ msgstr "" msgid "v" msgstr "" -#. 0: pending.release.url !== pending.release.id && ( <>
from {pending.release.url} ) -#. 0: release && release !== releaseId && ( <>
from{' '} {/^https?:\\\\/\\\\//.test(release) ? ( {release} ) \\: ( release )} ) -#: src/chunks/Plugins/InstallationReviewDialog.tsx -#: src/views/Installation/InstallationPage.tsx -msgid "Pinned to <0/> {0}" -msgstr "" +#~ msgid "Pinned to <0/> {0}" +#~ msgstr "" #: src/chunks/Plugins/CapabilityList.tsx msgid "No permissions required" @@ -9424,3 +9420,17 @@ msgstr "" #: src/chunks/AppPage/AppFrame.tsx msgid "Connect an account" msgstr "" + +#: src/chunks/Plugins/InstallationReviewDialog.tsx +#: src/views/Installation/InstallationPage.tsx +msgid "Pinned to <0/>" +msgstr "" + +#. 0: pending.release.url +#: src/chunks/Plugins/InstallationReviewDialog.tsx +msgid "from {0}" +msgstr "" + +#: src/views/Installation/InstallationPage.tsx +msgid "from" +msgstr "" diff --git a/browser/data-browser/src/locales/en.po b/browser/data-browser/src/locales/en.po index 22960acfe1..89026754c4 100644 --- a/browser/data-browser/src/locales/en.po +++ b/browser/data-browser/src/locales/en.po @@ -8869,12 +8869,8 @@ msgstr "Use included AI" msgid "v" msgstr "v" -#. 0: pending.release.url !== pending.release.id && ( <>
from {pending.release.url} ) -#. 0: release && release !== releaseId && ( <>
from{' '} {/^https?:\\\\/\\\\//.test(release) ? ( {release} ) \\: ( release )} ) -#: src/chunks/Plugins/InstallationReviewDialog.tsx -#: src/views/Installation/InstallationPage.tsx -msgid "Pinned to <0/> {0}" -msgstr "Pinned to <0/> {0}" +#~ msgid "Pinned to <0/> {0}" +#~ msgstr "Pinned to <0/> {0}" #: src/chunks/Plugins/CapabilityList.tsx msgid "No permissions required" @@ -9442,3 +9438,17 @@ msgstr "This app wants to connect your{0} <0/> account through{1} {2}. The conne #: src/chunks/AppPage/AppFrame.tsx msgid "Connect an account" msgstr "Connect an account" + +#: src/chunks/Plugins/InstallationReviewDialog.tsx +#: src/views/Installation/InstallationPage.tsx +msgid "Pinned to <0/>" +msgstr "Pinned to <0/>" + +#. 0: pending.release.url +#: src/chunks/Plugins/InstallationReviewDialog.tsx +msgid "from {0}" +msgstr "from {0}" + +#: src/views/Installation/InstallationPage.tsx +msgid "from" +msgstr "from" diff --git a/browser/data-browser/src/locales/es.po b/browser/data-browser/src/locales/es.po index 58f207142a..ddcddc62e2 100644 --- a/browser/data-browser/src/locales/es.po +++ b/browser/data-browser/src/locales/es.po @@ -8858,12 +8858,8 @@ msgstr "" msgid "v" msgstr "" -#. 0: pending.release.url !== pending.release.id && ( <>
from {pending.release.url} ) -#. 0: release && release !== releaseId && ( <>
from{' '} {/^https?:\\\\/\\\\//.test(release) ? ( {release} ) \\: ( release )} ) -#: src/chunks/Plugins/InstallationReviewDialog.tsx -#: src/views/Installation/InstallationPage.tsx -msgid "Pinned to <0/> {0}" -msgstr "" +#~ msgid "Pinned to <0/> {0}" +#~ msgstr "" #: src/chunks/Plugins/CapabilityList.tsx msgid "No permissions required" @@ -9424,3 +9420,17 @@ msgstr "" #: src/chunks/AppPage/AppFrame.tsx msgid "Connect an account" msgstr "" + +#: src/chunks/Plugins/InstallationReviewDialog.tsx +#: src/views/Installation/InstallationPage.tsx +msgid "Pinned to <0/>" +msgstr "" + +#. 0: pending.release.url +#: src/chunks/Plugins/InstallationReviewDialog.tsx +msgid "from {0}" +msgstr "" + +#: src/views/Installation/InstallationPage.tsx +msgid "from" +msgstr "" diff --git a/browser/data-browser/src/locales/fr.po b/browser/data-browser/src/locales/fr.po index b43fb625f4..2af8368b99 100644 --- a/browser/data-browser/src/locales/fr.po +++ b/browser/data-browser/src/locales/fr.po @@ -8858,12 +8858,8 @@ msgstr "" msgid "v" msgstr "" -#. 0: pending.release.url !== pending.release.id && ( <>
from {pending.release.url} ) -#. 0: release && release !== releaseId && ( <>
from{' '} {/^https?:\\\\/\\\\//.test(release) ? ( {release} ) \\: ( release )} ) -#: src/chunks/Plugins/InstallationReviewDialog.tsx -#: src/views/Installation/InstallationPage.tsx -msgid "Pinned to <0/> {0}" -msgstr "" +#~ msgid "Pinned to <0/> {0}" +#~ msgstr "" #: src/chunks/Plugins/CapabilityList.tsx msgid "No permissions required" @@ -9424,3 +9420,17 @@ msgstr "" #: src/chunks/AppPage/AppFrame.tsx msgid "Connect an account" msgstr "" + +#: src/chunks/Plugins/InstallationReviewDialog.tsx +#: src/views/Installation/InstallationPage.tsx +msgid "Pinned to <0/>" +msgstr "" + +#. 0: pending.release.url +#: src/chunks/Plugins/InstallationReviewDialog.tsx +msgid "from {0}" +msgstr "" + +#: src/views/Installation/InstallationPage.tsx +msgid "from" +msgstr "" diff --git a/browser/data-browser/src/views/Installation/InstallationPage.tsx b/browser/data-browser/src/views/Installation/InstallationPage.tsx index 614007405d..27ef1a8110 100644 --- a/browser/data-browser/src/views/Installation/InstallationPage.tsx +++ b/browser/data-browser/src/views/Installation/InstallationPage.tsx @@ -279,22 +279,24 @@ export const InstallationPage: React.FC<

Release

+ {/* Two paragraphs, not a
inside one message: a JSX element + passed into a translated message lands in its fragment array + without a key. */} Pinned to {releaseId} - {release && release !== releaseId && ( - <> -
- from{' '} - {/^https?:\/\//.test(release) ? ( - - {release} - - ) : ( - release - )} - - )}
+ {release && release !== releaseId && ( + + from{' '} + {/^https?:\/\//.test(release) ? ( + + {release} + + ) : ( + release + )} + + )}

Grants