From 060460eb4259dde724bf84fbaace958c62f07219 Mon Sep 17 00:00:00 2001 From: Michiel de Jong Date: Fri, 13 Nov 2026 16:54:54 +0000 Subject: [PATCH 1/5] Extract the grid and editors through canonical UI and pure helpers --- .dagger/src/index.ts | 7 + .github/workflows/shared-ui.yml | 6 + .github/workflows/table-package.yml | 70 ++ TESTING_COVERAGE.md | 10 +- browser/data-browser/package.json | 1 + .../TableEditor/ActiveCellIndicator.tsx | 232 +------ .../src/chunks/TableEditor/AtomicTable.tsx | 25 + .../src/chunks/TableEditor/Cell.tsx | 488 +------------- .../src/chunks/TableEditor/DndWrapper.tsx | 25 +- .../chunks/TableEditor/ReorderDropArea.tsx | 37 +- .../src/chunks/TableEditor/TableEditor.tsx | 633 +----------------- .../chunks/TableEditor/TableEditorContext.tsx | 315 +-------- .../src/chunks/TableEditor/TableHeader.tsx | 145 +--- .../src/chunks/TableEditor/TableHeading.tsx | 131 +--- .../src/chunks/TableEditor/TableRow.tsx | 66 +- .../chunks/TableEditor/helpers/clipboard.ts | 87 +-- .../TableEditor/helpers/indicatorPosition.ts | 100 +-- .../TableEditor/helpers/keyboardHandlers.ts | 419 +----------- .../TableEditor/helpers/reorderArray.ts | 12 +- .../TableEditor/helpers/scrollIntoView.ts | 36 +- .../TableEditor/helpers/selectionBounds.ts | 37 +- .../TableEditor/hooks/useAvailableHeight.ts | 138 +--- .../TableEditor/hooks/useCellOptions.ts | 70 +- .../chunks/TableEditor/hooks/useCellSizes.ts | 114 +--- .../TableEditor/hooks/useClearCommands.ts | 33 +- .../TableEditor/hooks/useCopyCommand.ts | 32 +- .../TableEditor/hooks/useDragSensors.ts | 27 +- .../TableEditor/hooks/useGetSelectedCells.ts | 93 +-- .../TableEditor/hooks/usePasteCommand.ts | 65 +- .../useTableEditorKeyboardNavigation.tsx | 135 +--- .../src/chunks/TableEditor/index.tsx | 8 +- .../src/chunks/TableEditor/types.ts | 18 +- .../TablePage/EditorCells/BooleanCell.tsx | 26 +- .../chunks/TablePage/EditorCells/DateCell.tsx | 39 +- .../chunks/TablePage/EditorCells/InputBase.ts | 11 +- .../TablePage/EditorCells/IntegerCell.tsx | 26 +- .../TablePage/EditorCells/StringCell.tsx | 45 +- .../TablePage/EditorCells/TruncatedText.tsx | 93 +-- .../TablePage/EditorCells/numberInput.ts | 54 +- .../TablePage/EditorCells/useCommittedText.ts | 124 +--- .../src/chunks/TablePage/TableCell.test.tsx | 11 + .../src/components/VisuallyHidden.ts | 13 +- .../src/helpers/dates/calendarDate.ts | 54 +- .../src/helpers/dates/dateInput.ts | 128 +--- browser/data-browser/src/locales/de.po | 33 +- browser/data-browser/src/locales/en.po | 33 +- browser/data-browser/src/locales/es.po | 33 +- browser/data-browser/src/locales/fr.po | 33 +- browser/data-browser/src/locales/id.po | 33 +- browser/data-browser/src/locales/nl.po | 33 +- browser/data-browser/tsconfig.build.json | 1 + browser/data-browser/tsconfig.json | 1 + browser/data-browser/vite.config.ts | 4 + browser/lib/package.json | 3 +- browser/lib/src/EventManager.ts | 66 +- browser/lib/src/calendar-date.ts | 74 +- browser/lib/tsup.config.ts | 10 +- browser/package.json | 4 +- browser/pnpm-lock.yaml | 87 ++- browser/table/LICENSE | 33 + browser/table/README.md | 68 ++ browser/table/build.mjs | 17 + browser/table/package.json | 62 ++ browser/table/scripts/check-package.mjs | 121 ++++ .../TableEditor/ActiveCellIndicator.tsx | 232 +++++++ browser/table/src/chunks/TableEditor/Cell.tsx | 492 ++++++++++++++ .../src/chunks/TableEditor/DndWrapper.tsx | 24 + .../chunks/TableEditor/ReorderDropArea.tsx | 38 ++ .../TableEditor/TableEditor.keyboard.test.tsx | 14 +- .../chunks/TableEditor/TableEditor.test.tsx | 30 +- .../src/chunks/TableEditor/TableEditor.tsx | 633 ++++++++++++++++++ .../chunks/TableEditor/TableEditorContext.tsx | 314 +++++++++ .../src/chunks/TableEditor/TableHeader.tsx | 145 ++++ .../src/chunks/TableEditor/TableHeading.tsx | 131 ++++ .../table/src/chunks/TableEditor/TableRow.tsx | 66 ++ .../chunks/TableEditor/helpers/clipboard.ts | 86 +++ .../TableEditor/helpers/indicatorPosition.ts | 99 +++ .../helpers/keyboardHandlers.mod.test.ts | 2 +- .../TableEditor/helpers/keyboardHandlers.ts | 418 ++++++++++++ .../TableEditor/helpers/reorderArray.test.ts | 2 +- .../TableEditor/helpers/reorderArray.ts | 11 + .../TableEditor/helpers/scrollIntoView.ts | 35 + .../TableEditor/helpers/selectionBounds.ts | 36 + .../hooks/useAvailableHeight.test.ts | 2 +- .../TableEditor/hooks/useAvailableHeight.ts | 137 ++++ .../TableEditor/hooks/useCellOptions.ts | 69 ++ .../chunks/TableEditor/hooks/useCellSizes.ts | 113 ++++ .../TableEditor/hooks/useClearCommands.ts | 32 + .../TableEditor/hooks/useCopyCommand.ts | 31 + .../TableEditor/hooks/useDragSensors.ts | 26 + .../TableEditor/hooks/useGetSelectedCells.ts | 92 +++ .../TableEditor/hooks/usePasteCommand.ts | 64 ++ .../useTableEditorKeyboardNavigation.tsx | 134 ++++ .../table/src/chunks/TableEditor/index.tsx | 6 + browser/table/src/chunks/TableEditor/types.ts | 17 + .../TablePage/EditorCells/BooleanCell.tsx | 25 + .../chunks/TablePage/EditorCells/DateCell.tsx | 57 ++ .../chunks/TablePage/EditorCells/InputBase.ts | 11 + .../TablePage/EditorCells/IntegerCell.tsx | 44 ++ .../TablePage/EditorCells/StringCell.tsx | 44 ++ .../TablePage/EditorCells/TruncatedText.tsx | 93 +++ .../src/chunks/TablePage/EditorCells/Type.ts | 35 + .../TablePage/EditorCells/numberInput.ts | 47 ++ .../TablePage/EditorCells/useCommittedText.ts | 123 ++++ browser/table/src/host.tsx | 34 + browser/table/src/index.ts | 66 ++ browser/table/src/theme.ts | 27 + browser/table/src/value.ts | 7 + browser/table/tsconfig.json | 25 + browser/table/vitest.config.ts | 6 + browser/ui/README.md | 4 +- browser/ui/build.mjs | 18 +- browser/ui/package.json | 3 +- browser/ui/src/components/VisuallyHidden.ts | 12 + browser/ui/src/helpers/EventManager.ts | 1 + browser/ui/src/helpers/dates/calendarDate.ts | 53 ++ browser/ui/src/helpers/dates/dateInput.ts | 127 ++++ .../ui/src/helpers/dates/isCalendarDate.ts | 1 + browser/utils/README.md | 6 + browser/utils/package.json | 25 + .../{lib => utils}/src/EventManager.test.ts | 0 browser/utils/src/EventManager.ts | 65 ++ .../{lib => utils}/src/calendar-date.test.ts | 0 browser/utils/src/calendar-date.ts | 73 ++ browser/utils/tsconfig.json | 18 + browser/utils/vitest.config.ts | 3 + planning/table-workspace-package.md | 103 +++ planning/tablepage-extraction-reset.md | 11 +- scripts/bump-version.mjs | 2 + server/build.rs | 2 + 130 files changed, 5340 insertions(+), 4350 deletions(-) create mode 100644 .github/workflows/table-package.yml create mode 100644 browser/data-browser/src/chunks/TableEditor/AtomicTable.tsx create mode 100644 browser/table/LICENSE create mode 100644 browser/table/README.md create mode 100644 browser/table/build.mjs create mode 100644 browser/table/package.json create mode 100644 browser/table/scripts/check-package.mjs create mode 100644 browser/table/src/chunks/TableEditor/ActiveCellIndicator.tsx create mode 100644 browser/table/src/chunks/TableEditor/Cell.tsx create mode 100644 browser/table/src/chunks/TableEditor/DndWrapper.tsx create mode 100644 browser/table/src/chunks/TableEditor/ReorderDropArea.tsx rename browser/{data-browser => table}/src/chunks/TableEditor/TableEditor.keyboard.test.tsx (96%) rename browser/{data-browser => table}/src/chunks/TableEditor/TableEditor.test.tsx (61%) create mode 100644 browser/table/src/chunks/TableEditor/TableEditor.tsx create mode 100644 browser/table/src/chunks/TableEditor/TableEditorContext.tsx create mode 100644 browser/table/src/chunks/TableEditor/TableHeader.tsx create mode 100644 browser/table/src/chunks/TableEditor/TableHeading.tsx create mode 100644 browser/table/src/chunks/TableEditor/TableRow.tsx create mode 100644 browser/table/src/chunks/TableEditor/helpers/clipboard.ts create mode 100644 browser/table/src/chunks/TableEditor/helpers/indicatorPosition.ts rename browser/{data-browser => table}/src/chunks/TableEditor/helpers/keyboardHandlers.mod.test.ts (93%) create mode 100644 browser/table/src/chunks/TableEditor/helpers/keyboardHandlers.ts rename browser/{data-browser => table}/src/chunks/TableEditor/helpers/reorderArray.test.ts (85%) create mode 100644 browser/table/src/chunks/TableEditor/helpers/reorderArray.ts create mode 100644 browser/table/src/chunks/TableEditor/helpers/scrollIntoView.ts create mode 100644 browser/table/src/chunks/TableEditor/helpers/selectionBounds.ts rename browser/{data-browser => table}/src/chunks/TableEditor/hooks/useAvailableHeight.test.ts (97%) create mode 100644 browser/table/src/chunks/TableEditor/hooks/useAvailableHeight.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useCellOptions.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useCellSizes.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useClearCommands.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useCopyCommand.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useDragSensors.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useGetSelectedCells.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/usePasteCommand.ts create mode 100644 browser/table/src/chunks/TableEditor/hooks/useTableEditorKeyboardNavigation.tsx create mode 100644 browser/table/src/chunks/TableEditor/index.tsx create mode 100644 browser/table/src/chunks/TableEditor/types.ts create mode 100644 browser/table/src/chunks/TablePage/EditorCells/BooleanCell.tsx create mode 100644 browser/table/src/chunks/TablePage/EditorCells/DateCell.tsx create mode 100644 browser/table/src/chunks/TablePage/EditorCells/InputBase.ts create mode 100644 browser/table/src/chunks/TablePage/EditorCells/IntegerCell.tsx create mode 100644 browser/table/src/chunks/TablePage/EditorCells/StringCell.tsx create mode 100644 browser/table/src/chunks/TablePage/EditorCells/TruncatedText.tsx create mode 100644 browser/table/src/chunks/TablePage/EditorCells/Type.ts create mode 100644 browser/table/src/chunks/TablePage/EditorCells/numberInput.ts create mode 100644 browser/table/src/chunks/TablePage/EditorCells/useCommittedText.ts create mode 100644 browser/table/src/host.tsx create mode 100644 browser/table/src/index.ts create mode 100644 browser/table/src/theme.ts create mode 100644 browser/table/src/value.ts create mode 100644 browser/table/tsconfig.json create mode 100644 browser/table/vitest.config.ts create mode 100644 browser/ui/src/components/VisuallyHidden.ts create mode 100644 browser/ui/src/helpers/EventManager.ts create mode 100644 browser/ui/src/helpers/dates/calendarDate.ts create mode 100644 browser/ui/src/helpers/dates/dateInput.ts create mode 100644 browser/ui/src/helpers/dates/isCalendarDate.ts create mode 100644 browser/utils/README.md create mode 100644 browser/utils/package.json rename browser/{lib => utils}/src/EventManager.test.ts (100%) create mode 100644 browser/utils/src/EventManager.ts rename browser/{lib => utils}/src/calendar-date.test.ts (100%) create mode 100644 browser/utils/src/calendar-date.ts create mode 100644 browser/utils/tsconfig.json create mode 100644 browser/utils/vitest.config.ts create mode 100644 planning/table-workspace-package.md diff --git a/.dagger/src/index.ts b/.dagger/src/index.ts index 80d36e32cf..0700fe9efd 100644 --- a/.dagger/src/index.ts +++ b/.dagger/src/index.ts @@ -1094,6 +1094,8 @@ export class AtomicServer { browser.file('data-browser/package.json'), ) .withFile('/repo/browser/ui/package.json', browser.file('ui/package.json')) + .withFile('/repo/browser/utils/package.json', browser.file('utils/package.json')) + .withFile('/repo/browser/table/package.json', browser.file('table/package.json')) .withFile( '/repo/browser/lib/package.json', browser.file('lib/package.json'), @@ -1154,6 +1156,7 @@ export class AtomicServer { // integration tests, except @tomic/mcp: hosted-mcp.integration.test.ts // imports its bridge from `../../mcp/src`. const withSource = installed + .withDirectory('/repo/browser/utils', browser.directory('utils')) .withDirectory('/repo/browser/lib', browser.directory('lib')) .withDirectory('/repo/browser/mcp', browser.directory('mcp')); @@ -1162,6 +1165,8 @@ export class AtomicServer { permissions: 0o755, }) .withDirectory('/repo/wasm/pkg', wasmPkg) + .withWorkdir('/repo/browser/utils') + .withExec(['pnpm', 'run', 'build']) .withWorkdir('/repo/browser/lib') .withExec(['pnpm', 'run', 'test:integration']) .stdout(); @@ -1358,6 +1363,8 @@ export class AtomicServer { browser.file('data-browser/package.json'), ) .withFile('/app/ui/package.json', browser.file('ui/package.json')) + .withFile('/app/utils/package.json', browser.file('utils/package.json')) + .withFile('/app/table/package.json', browser.file('table/package.json')) .withFile('/app/lib/package.json', browser.file('lib/package.json')) .withFile('/app/react/package.json', browser.file('react/package.json')) .withFile('/app/svelte/package.json', browser.file('svelte/package.json')) diff --git a/.github/workflows/shared-ui.yml b/.github/workflows/shared-ui.yml index 31560fbe6f..e823580584 100644 --- a/.github/workflows/shared-ui.yml +++ b/.github/workflows/shared-ui.yml @@ -4,6 +4,10 @@ on: pull_request: paths: - 'browser/ui/**' + - 'browser/utils/**' + - 'browser/lib/src/EventManager.ts' + - 'browser/lib/src/calendar-date.ts' + - 'browser/lib/tsup.config.ts' - 'browser/data-browser/src/components/**' - 'browser/data-browser/src/hooks/**' - 'browser/data-browser/src/globalCssVars.ts' @@ -26,6 +30,8 @@ jobs: cache-dependency-path: browser/pnpm-lock.yaml - run: pnpm install --frozen-lockfile working-directory: browser + - run: pnpm --filter @tomic/utils build && pnpm --filter @tomic/utils test + working-directory: browser - run: pnpm --filter @tomic/ui lint && pnpm --filter @tomic/ui typecheck working-directory: browser - run: pnpm --filter '@tomic/data-browser^...' build diff --git a/.github/workflows/table-package.yml b/.github/workflows/table-package.yml new file mode 100644 index 0000000000..c9fa8421fa --- /dev/null +++ b/.github/workflows/table-package.yml @@ -0,0 +1,70 @@ +name: Table package + +on: + pull_request: + paths: + - 'browser/table/**' + - 'browser/ui/**' + - 'browser/utils/**' + - 'browser/pnpm-lock.yaml' + - 'browser/pnpm-workspace.yaml' + - 'browser/package.json' + - 'browser/.ox*' + - '.github/workflows/table-package.yml' + push: + branches: [develop] + paths: + - 'browser/table/**' + - 'browser/ui/**' + - 'browser/utils/**' + - 'browser/pnpm-lock.yaml' + - 'browser/pnpm-workspace.yaml' + - 'browser/package.json' + - 'browser/.ox*' + - '.github/workflows/table-package.yml' + workflow_dispatch: + +permissions: + contents: read + +concurrency: + group: table-package-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + package: + name: Build, test and install packed table + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: '24' + - uses: pnpm/action-setup@v4 + with: + version: 11.10.0 + - name: Install table dependencies + working-directory: browser + run: pnpm --filter @tomic/table... install --frozen-lockfile + - name: Build shared UI + working-directory: browser + run: pnpm --filter @tomic/ui... build + - name: Lint, typecheck and test + working-directory: browser + run: | + pnpm --filter @tomic/table lint + pnpm --filter @tomic/table typecheck + pnpm --filter @tomic/table test + - name: Build and pack + working-directory: browser + run: | + pnpm --filter @tomic/table pack --out "$RUNNER_TEMP/tomic-table.tgz" + pnpm --filter @tomic/ui pack --out "$RUNNER_TEMP/tomic-ui.tgz" + - name: Install and typecheck a clean external consumer + run: node browser/table/scripts/check-package.mjs "$RUNNER_TEMP/tomic-table.tgz" "$RUNNER_TEMP/tomic-ui.tgz" + - uses: actions/upload-artifact@v4 + with: + name: tomic-table-preview + path: | + ${{ runner.temp }}/tomic-table.tgz + ${{ runner.temp }}/tomic-ui.tgz diff --git a/TESTING_COVERAGE.md b/TESTING_COVERAGE.md index 1cd5780d7c..a0f3d45690 100644 --- a/TESTING_COVERAGE.md +++ b/TESTING_COVERAGE.md @@ -1,3 +1,11 @@ +Grid extraction and shared helpers: `browser/table/src` retains the existing grid, +keyboard, selection and primitive-editor tests. The SDK's EventManager and civil +calendar tests move with their implementations to `browser/utils/src` (nine +cases). Both SDK and UI builds include the private helper modules' declarations; +packed-consumer checks verify the grid uses the host's UI module instance. +TableCell's local fixture seeds createdAt metadata to avoid external HTTP reads +while asserting cell commits. These changes do not introduce new state policies. + Shared UI extraction: `browser/data-browser/src/components/sharedUI.test.tsx` checks that compatibility paths and the extracted package share keyboard locks, the dialog tree and generated background CSS variables. Existing spinner, @@ -2107,7 +2115,7 @@ number by keyboard, or a click on the day's empty space) shows every event and opens each row on top of it. How many chips fit is measured, so it needs a real browser; jsdom can't cover it. -All-day ranges: `browser/lib/src/calendar-date.test.ts` covers civil-date +All-day ranges: `browser/utils/src/calendar-date.test.ts` covers civil-date validation, exclusive single/multi-day ends, leap days, DST dates and year boundaries; run under UTC, America/Los_Angeles and Pacific/Kiritimati. diff --git a/browser/data-browser/package.json b/browser/data-browser/package.json index 10d26c7a59..d749d8cbb0 100644 --- a/browser/data-browser/package.json +++ b/browser/data-browser/package.json @@ -56,6 +56,7 @@ "@tomic/plugin": "workspace:*", "@tomic/react": "workspace:*", "@tomic/service-ui": "workspace:*", + "@tomic/table": "workspace:*", "@tomic/ui": "workspace:*", "@uiw/codemirror-theme-github": "^4.25.10", "@uiw/react-codemirror": "^4.25.10", diff --git a/browser/data-browser/src/chunks/TableEditor/ActiveCellIndicator.tsx b/browser/data-browser/src/chunks/TableEditor/ActiveCellIndicator.tsx index 2d74d7db65..957a27616e 100644 --- a/browser/data-browser/src/chunks/TableEditor/ActiveCellIndicator.tsx +++ b/browser/data-browser/src/chunks/TableEditor/ActiveCellIndicator.tsx @@ -1,231 +1 @@ -import { transparentize } from 'polished'; -import { useCallback, useEffect, useState, type JSX } from 'react'; -import { styled } from 'styled-components'; -import { - getHeight, - getLeft, - getTop, - getTopBasedOnPreviousHeight, - getWidth, -} from './helpers/indicatorPosition'; -import { scrollIntoView } from './helpers/scrollIntoView'; -import { CursorMode, useTableEditorContext } from './TableEditorContext'; - -type OnScrollCallbackOptions = { - scrollUpdateWasRequested: boolean; -}; - -export interface ActiveCellIndicatorProps { - sizeStr: string; - scrollerRef: React.RefObject; - setOnScroll: ( - onScroll: ({ scrollUpdateWasRequested }: OnScrollCallbackOptions) => void, - ) => void; -} - -const cursorGoesOffscreen = (parentRect: DOMRect, childRect: DOMRect) => { - return childRect.left < parentRect.left || childRect.right > parentRect.right; -}; - -const getCornerIfMultiSelect = ( - cursorMode: CursorMode, - ref: React.RefObject, -) => { - if (cursorMode === CursorMode.MultiSelect && ref.current) { - return ref.current.getBoundingClientRect(); - } - - return undefined; -}; - -export function ActiveCellIndicator({ - sizeStr, - scrollerRef, - setOnScroll, -}: ActiveCellIndicatorProps): JSX.Element | null { - const [visible, setVisible] = useState(false); - const [scrolling, setScrolling] = useState(false); - const [transitioningOffscreen, setTransitioningOffscreen] = useState(false); - - const [{ top, left, width, height }, setSize] = useState({ - top: 0, - left: 0, - width: 0, - height: 0, - }); - - const { - selectedColumn, - selectedRow, - multiSelectCornerColumn, - multiSelectCornerRow, - activeCellRef, - isDragging, - cursorMode, - indicatorHidden, - multiSelectCornerCellRef, - } = useTableEditorContext(); - - /** Measure the size and position of the current active cell and morph the indicator to the same values. */ - const updatePosition = useCallback( - (followHorizontally = true) => { - if (!activeCellRef.current || !scrollerRef.current) { - setVisible(false); - - return; - } - - const cellRect = activeCellRef.current.getBoundingClientRect(); - const scrollerRect = scrollerRef.current.getBoundingClientRect(); - - const cornerRect = getCornerIfMultiSelect( - cursorMode, - multiSelectCornerCellRef, - ); - - if (followHorizontally && cursorGoesOffscreen(scrollerRect, cellRect)) { - setTransitioningOffscreen(true); - - scrollIntoView(scrollerRef.current, scrollerRect, cellRect); - } else { - setTransitioningOffscreen(false); - } - - if ( - cursorMode === CursorMode.MultiSelect && - (cellRect.height === 0 || cornerRect?.height === 0) - ) { - setSize(prev => ({ - top: getTopBasedOnPreviousHeight( - scrollerRect.top, - cellRect, - cornerRect!, - prev.height, - (selectedRow ?? 0) < (multiSelectCornerRow ?? 0), - ), - left: prev.left, - width: prev.width, - height: prev.height, - })); - - return; - } - - setSize({ - top: getTop(scrollerRect.top, cellRect, cornerRect), - left: getLeft( - scrollerRect.left, - scrollerRef.current!.scrollLeft!, - cellRect, - cornerRect, - ), - width: selectedColumn === 0 ? -1 : getWidth(cellRect, cornerRect), - height: getHeight(cellRect, cornerRect), - }); - }, - [ - selectedColumn, - selectedRow, - sizeStr, - cursorMode, - multiSelectCornerColumn, - multiSelectCornerRow, - ], - ); - - useEffect(() => { - setOnScroll( - () => - ({ scrollUpdateWasRequested }: OnScrollCallbackOptions) => { - if (scrollUpdateWasRequested) { - return; - } - - setScrolling(true); - updatePosition(false); - }, - ); - }, [updatePosition]); - - useEffect(() => { - if (selectedColumn === undefined || selectedRow === undefined) { - setVisible(false); - - return; - } - - setVisible(true); - setScrolling(false); - updatePosition(); - }, [ - selectedColumn, - selectedRow, - multiSelectCornerColumn, - multiSelectCornerRow, - ]); - - useEffect(() => { - if (cursorMode === CursorMode.MultiSelect) { - updatePosition(false); - } - }, [cursorMode, multiSelectCornerCellRef]); - - // When a user is changing the width of a column the indicator should change with it but should not trigger the horizontal auto following. - useEffect(() => { - setScrolling(false); - updatePosition(false); - }, [sizeStr]); - - if (!visible) { - return ; - } - - return ( -