Skip to content

feat: support named data-residency endpoints - #2393

Merged
apcha-oai merged 1 commit into
mainfrom
castiron/promotions/pr-64
Aug 18, 2026
Merged

apcha-oai merged 1 commit into
mainfrom
castiron/promotions/pr-64

Conversation

@apcha-oai

@apcha-oai apcha-oai commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Let applications select an OpenAI regional endpoint by name instead of assembling base URLs themselves. dataResidency supports global, us, eu, and ae, and works consistently when creating or copying a client.

Conflicting explicit endpoints and third-party provider combinations fail locally. The selected endpoint does not change project eligibility or provide regional fallback.

The Azure clone-typing review finding is fixed in custom code to unblock merge. AzureOpenAI.withOptions now uses Azure-specific options, matching Bedrock, with a focused compile-time regression. Runtime rejection is unchanged.

@openai-sdks

openai-sdks Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 237/237 SDK tests passed in 11.849s for Node SDK PR #2393.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 245ms
tests/chat-completions-create.test.ts ✅ Passed 274ms
tests/chat-completions-stream.test.ts ✅ Passed 119ms
tests/files-content-binary.test.ts ✅ Passed 155ms
tests/files-create-multipart.test.ts ✅ Passed 297ms
tests/files-list-pagination.test.ts ✅ Passed 188ms
tests/initialize-config.test.ts ✅ Passed 255ms
tests/instance-isolation.test.ts ✅ Passed 173ms
tests/models-list.test.ts ✅ Passed 179ms
tests/responses-background-lifecycle.test.ts ✅ Passed 255ms
tests/responses-body-method-errors.test.ts ✅ Passed 446ms
tests/responses-cancel-timeout.test.ts ✅ Passed 283ms
tests/responses-cancel.test.ts ✅ Passed 317ms
tests/responses-compact-retries.test.ts ✅ Passed 305ms
tests/responses-compact.test.ts ✅ Passed 281ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 198ms
tests/responses-create-advanced.test.ts ✅ Passed 178ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.143s
tests/responses-create-errors.test.ts ✅ Passed 256ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 168ms
tests/responses-create-retries.test.ts ✅ Passed 330ms
tests/responses-create-stream-failures.test.ts ✅ Passed 240ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.183s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.513s
tests/responses-create-stream.test.ts ✅ Passed 207ms
tests/responses-create-terminal-states.test.ts ✅ Passed 289ms
tests/responses-create-timeout.test.ts ✅ Passed 351ms
tests/responses-create.test.ts ✅ Passed 315ms
tests/responses-delete.test.ts ✅ Passed 371ms
tests/responses-input-items-errors.test.ts ✅ Passed 175ms
tests/responses-input-items-list.test.ts ✅ Passed 201ms
tests/responses-input-items-options.test.ts ✅ Passed 241ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 306ms
tests/responses-input-tokens-count.test.ts ✅ Passed 323ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.304s
tests/responses-not-found-errors.test.ts ✅ Passed 299ms
tests/responses-parse.test.ts ✅ Passed 266ms
tests/responses-retrieve-retries.test.ts ✅ Passed 318ms
tests/responses-retrieve.test.ts ✅ Passed 324ms
tests/responses-stored-method-errors.test.ts ✅ Passed 582ms
tests/retry-behavior.test.ts ✅ Passed 3.193s
tests/sdk-error-shape.test.ts ✅ Passed 454ms

View OkTest run #32150478444

SDK merge (3262d6c933c7) · head (385244b56c54) · base (a88c2caa8a2e) · OkTest (7e7850017529)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddf043858c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/azure.ts Resolved

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing Codex inline comment identifies one confirmed compatibility issue: AzureOpenAI inherits withOptions(Partial<ClientOptions>), so unsupported dataResidency values type-check on Azure clones even though construction always rejects them. Override withOptions with Partial<AzureClientOptions>, matching the existing Bedrock implementation, and add a focused type regression. The remainder of the regional endpoint behavior and exact-head CI are sound. Existing inline: #2393 (comment)

Castiron-Internal-PR: openai/openai-node-internal#64
Castiron-Source-SHA: 0aa6447abd0305530a272747e55e090470a88386
Castiron-Public-Base-SHA: a88c2ca

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the updated exact head after the requested Azure typing fix. AzureOpenAI.withOptions now accepts Partial<AzureClientOptions>, matching the existing Bedrock ownership boundary, and the focused public regression proves unsupported regional options fail both TypeScript checking and runtime validation. Regional endpoint selection, provider conflicts, streaming, environment precedence, and client cloning remain sound. Exact-head CI is fully green; no actionable findings.

@apcha-oai
apcha-oai added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 62d98dd Aug 18, 2026
27 checks passed
@apcha-oai
apcha-oai deleted the castiron/promotions/pr-64 branch August 18, 2026 15:03
@openai-sdks openai-sdks Bot mentioned this pull request Aug 17, 2026

This branch was successfully deployed

1 active deployment
ci — 385244b5 Deployed Aug 18, 2026 by apcha-oai via ecosystem tests #8367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants