Repository navigation
fix(streaming): reject named SSE provider error events - #2409
Merged
Merged
Conversation
Contributor
jbeckwith-oai
approved these changes
Aug 18, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Independent two-pass review: named SSE provider errors are correctly converted into APIError while preserving nested error behavior, response metadata, request IDs, assistant envelopes, cancellation, and sanitized malformed-event diagnostics. No actionable findings.
Merged
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event: errorframes as typedAPIErrors instead of yielding flat provider failures as successful Chat Completions, Responses, and Assistants stream events.Validation
new OpenAI({ fetch })public streaming APIs and both exported event-synthesis modes incorrectly fulfilled before the fix.OPENAI_TEST_SUITE=unit pnpm test -- --maxWorkers=6— 3,531 handwritten tests passed.OPENAI_TEST_SUITE=generated pnpm test -- --runInBand— 559 generated tests passed.pnpm lint— zero errors and warnings.pnpm exec tsc --pretty false;pnpm build.pnpm exec publint dist; packed-package CommonJS, ESM, and 267 source checks passed on Node 22.23.2 and 26.7.0.