Repository navigation
fix(security): authenticate Vercel ecosystem APIs and clean up uploaded files - #2412
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0964d4332c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbeckwith-oai
approved these changes
Aug 19, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Independent two-pass review: Vercel ecosystem routes enforce fail-closed bearer authentication, streamed request bodies honor the byte limit regardless of Content-Length, and uploaded files are cleaned up across success/error paths. The earlier request-size review finding is fixed. No actionable findings.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security findings
csf_60ad55d472f1de23a525c274: unauthenticated assistant listing exposes account data.csf_97c0b7e3dc03a6c21566a620: anonymous completion and streaming routes proxy paid model requests.csf_c2b9fc853edab3a40da1eb0f: anonymous transcription requests consume paid capacity.csf_3d634c846334bb5128ffb403andcsf_e2bb95e5859e20ee92db380c: public Edge/Node test routes incur charges and leave uploaded files behind.Changes
/api/*route before OpenAI client initialization; reject oversized requests and bound chat inputs/model output.finally, including assertion-failure paths, across both Edge and Node runtimes.ecosystem-tests/vercel-edge/**.Verification
node_modules/.bin/tsc --noEmit --incremental false.npm run build../scripts/lint.401; oversized authorized input returns413; authorized requests reach the existing handler; the public homepage remains200. No paid upstream requests were made.Rollout
Deployments must configure a private
VERCEL_EDGE_TEST_TOKENcontaining at least 32 characters; without it, API routes remain safely disabled. Existing ecosystem CI generates a fresh token automatically. Public SDK APIs and generated/upstream-owned files are unchanged.