Repository navigation
fix(security): require an exact SSE completion sentinel - #2422
Merged
HAYDEN-OAI merged 1 commit intoAug 19, 2026
Merged
Conversation
Contributor
jbeckwith-oai
approved these changes
Aug 19, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Independent two-pass security review confirms SSE streams now terminate only on the exact [DONE] sentinel. Forged suffixed or multiline events no longer truncate streams, while valid protocol framing, UTF-8 fragmentation, cancellation, diagnostics, and Chat/Responses/Assistants behavior remain compatible. Comprehensive regressions and substantive CI are green; no actionable findings.
HAYDEN-OAI
deleted the
codex/sse-completion-sentinel-integrity-20260819-2049
branch
August 19, 2026 21:07
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[DONE]SSE completion marker, preventing forged marker prefixes or multiline frames from silently truncating streams and suppressing provider errorsRegression-first proof
On unchanged
main, the new public-boundary suite produced 14 failures and 20 passing compatibility controls: malformed marker suffixes, sensitive appended payloads, multiline impersonation, hidden provider errors, and open-reader cleanup incorrectly completed successfully. The one-comparison fix makes all 34 tests pass.Validation
Stream.fromSSEResponse, rejecting forged markers while preserving genuine completionChanges are limited to one handwritten comparison and one dedicated regression file.