Repository navigation
feat(auth): add pinned X.509 workload token exchange - #2470
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32898186782 --repo openai/openai-node \
--name castiron-custom-code-32898186782-1 --dir /tmp/castiron-custom-code-32898186782-1
git apply --stat /tmp/castiron-custom-code-32898186782-1/custom-code.patch
cat /tmp/castiron-custom-code-32898186782-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 0d12ca8e5f15591b08f96c6f7b78e6271e21f874 c4dbb9cadd391f775252bd04bbe1b543b73fb60d
python3 scripts/castiron/custom_code_report.py report \
--base 0d12ca8e5f15591b08f96c6f7b78e6271e21f874 \
--head c4dbb9cadd391f775252bd04bbe1b543b73fb60d --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-c4dbb9cadd39
cat /tmp/castiron-custom-code-c4dbb9cadd39/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d99b529a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
left a comment
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed issuer and transport pinning, certificate boundaries, OAuth response validation, sensitive-error redaction, and cancellation/deadline handling. No additional substantive issues beyond the existing non-blocking cancellation-race comment.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4dbb9cadd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Part 1 of 5 in the X.509 workload-identity stack.
https://mtls.auth.openai.com/oauth/tokenissuer.Verification
pnpm lint,pnpm exec tsc --noEmit, andpnpm build.Next:
codex/x509-02-capability-boundary.