Repository navigation
feat(auth): attest cross-module X.509 transport capabilities - #2471
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f7f4cc7de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
left a comment
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed the frozen capability attestation, shared CJS/ESM registry identity, scoped transport callbacks, optional Undici isolation, and private package-export boundaries. No additional blocking issues; the existing source-mode resolver comment captures the remaining follow-up.
2f7f4cc to
cbeb6a7
Compare
90f888f to
71f47ec
Compare
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32902342574 --repo openai/openai-node \
--name castiron-custom-code-32902342574-1 --dir /tmp/castiron-custom-code-32902342574-1
git apply --stat /tmp/castiron-custom-code-32902342574-1/custom-code.patch
cat /tmp/castiron-custom-code-32902342574-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9dd86484d9d5a2212ea8ec472fad6f76c747ba14 8963a4165e2a34c77a2f5b4c7e2a1c26c770bd40
python3 scripts/castiron/custom_code_report.py report \
--base 9dd86484d9d5a2212ea8ec472fad6f76c747ba14 \
--head 8963a4165e2a34c77a2f5b4c7e2a1c26c770bd40 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-8963a4165e2a
cat /tmp/castiron-custom-code-8963a4165e2a/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71f47ecd1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e43f30aa01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Part 2 of 5; based on
codex/x509-01-token-exchange..ctsstate module without broadening package exports or losing its canonical identity.Verification
pnpm lint,pnpm exec tsc --noEmit,pnpm build, generated Jest smoke tests, and packed npm artifact/export checks on Node 22.Next:
codex/x509-03-client-integration.