Repository navigation
fix(bedrock): honor cancellation during bearer credential resolution - #2478
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33011759018 --repo openai/openai-node \
--name castiron-custom-code-33011759018-1 --dir /tmp/castiron-custom-code-33011759018-1
git apply --stat /tmp/castiron-custom-code-33011759018-1/custom-code.patch
cat /tmp/castiron-custom-code-33011759018-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 520d6044717790d922e9659427518850a80a0345 b228a78c937d115f98669ed2ecd80b739944e821
python3 scripts/castiron/custom_code_report.py report \
--base 520d6044717790d922e9659427518850a80a0345 \
--head b228a78c937d115f98669ed2ecd80b739944e821 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b228a78c937d
cat /tmp/castiron-custom-code-b228a78c937d/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38c97171a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Independently reviewed Bedrock bearer credential cancellation across both original and finalized request signals, signal deduplication, pre-abort handling, registration/cleanup races, exact abort causes, late credential rejection, provider-error propagation, and both provider entrypoints.
47c4cad to
bea8e45
Compare
bea8e45 to
86e6de4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86e6de4b1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
signalwhile a Bedrock bearertokenProvideris resolving, including dependency-free and AWS bearer provider entrypoints.Validation
new OpenAI({ provider: bedrock({ tokenProvider }), fetch }).models.list({ signal })requests across both provider entrypoints and Mantle/runtime endpoints, including retries, reentrant registration, throwing cleanup/getters, native Promise compatibility, NaN first-cause ownership, and late provider failures.