Skip to content

fix(standard-schema): preserve validator bindings across helpers - #2483

Merged
HAYDEN-OAI merged 1 commit into
mainfrom
codex/standard-schema-validator-bindings-20260826-mtafo4xu-0khdv4
Aug 26, 2026
Merged

HAYDEN-OAI merged 1 commit into
mainfrom
codex/standard-schema-validator-bindings-20260826-mtafo4xu-0khdv4

Conversation

@HAYDEN-OAI

Copy link
Copy Markdown
Contributor

Summary

  • Bind all four Standard Schema helpers to the same validator metadata used for strict schema generation.
  • Preserve explicit-schema laziness, original method receivers, and existing tool-option getter ordering.
  • Add focused integrated regressions for fresh metadata, converter mutation, validator swapping, and malformed JSON.

Validation

  • Node 22.23 and Node 26.7: 6,541 handwritten and 556 generated tests on each runtime.
  • Canonical lint, strict TypeScript 6, published TypeScript 4.9/6 declarations, and package builds on both runtimes.
  • publint and installed packed-package CJS/ESM adversarial helper checks on both runtimes.

@HAYDEN-OAI
HAYDEN-OAI requested a review from a team as a code owner August 26, 2026 18:35
@openai-sdks

openai-sdks Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 237/237 SDK tests passed in 10.163s for Node SDK PR #2483.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 145ms
tests/chat-completions-create.test.ts ✅ Passed 196ms
tests/chat-completions-stream.test.ts ✅ Passed 116ms
tests/files-content-binary.test.ts ✅ Passed 119ms
tests/files-create-multipart.test.ts ✅ Passed 188ms
tests/files-list-pagination.test.ts ✅ Passed 162ms
tests/initialize-config.test.ts ✅ Passed 171ms
tests/instance-isolation.test.ts ✅ Passed 117ms
tests/models-list.test.ts ✅ Passed 121ms
tests/responses-background-lifecycle.test.ts ✅ Passed 223ms
tests/responses-body-method-errors.test.ts ✅ Passed 303ms
tests/responses-cancel-timeout.test.ts ✅ Passed 252ms
tests/responses-cancel.test.ts ✅ Passed 190ms
tests/responses-compact-retries.test.ts ✅ Passed 244ms
tests/responses-compact.test.ts ✅ Passed 204ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 128ms
tests/responses-create-advanced.test.ts ✅ Passed 202ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.106s
tests/responses-create-errors.test.ts ✅ Passed 206ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 123ms
tests/responses-create-retries.test.ts ✅ Passed 240ms
tests/responses-create-stream-failures.test.ts ✅ Passed 223ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 2.167s
tests/responses-create-stream-wire.test.ts ✅ Passed 2.454s
tests/responses-create-stream.test.ts ✅ Passed 92ms
tests/responses-create-terminal-states.test.ts ✅ Passed 205ms
tests/responses-create-timeout.test.ts ✅ Passed 234ms
tests/responses-create.test.ts ✅ Passed 255ms
tests/responses-delete.test.ts ✅ Passed 242ms
tests/responses-input-items-errors.test.ts ✅ Passed 165ms
tests/responses-input-items-list.test.ts ✅ Passed 178ms
tests/responses-input-items-options.test.ts ✅ Passed 118ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 245ms
tests/responses-input-tokens-count.test.ts ✅ Passed 209ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.104s
tests/responses-not-found-errors.test.ts ✅ Passed 223ms
tests/responses-parse.test.ts ✅ Passed 165ms
tests/responses-retrieve-retries.test.ts ✅ Passed 243ms
tests/responses-retrieve.test.ts ✅ Passed 183ms
tests/responses-stored-method-errors.test.ts ✅ Passed 513ms
tests/retry-behavior.test.ts ✅ Passed 3.18s
tests/sdk-error-shape.test.ts ✅ Passed 294ms

View OkTest run #33000563701

SDK merge (c3d088f5fe1e) · head (e4e7ed9437c6) · base (60f5267509d7) · OkTest (2b1bdfd25e98)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-26T18:37:35.856323Z e4e7ed9 PR opened
🔒 Security Review ✅ Completed 2026-08-26T18:37:41.740052Z e4e7ed9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

32 mixed files remain; 0 existing customizations changed.

Compared 60f5267509d7 → e4e7ed9437c6. Generated baselines verified.

32 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/client.ts
  • src/resources/audio/transcriptions.ts
  • src/resources/audio/translations.ts
  • src/resources/beta/assistants.ts
  • src/resources/beta/beta.ts
  • src/resources/beta/index.ts
  • src/resources/beta/responses/internal-base.ts
  • src/resources/beta/responses/responses.ts
  • src/resources/beta/threads/index.ts
  • src/resources/beta/threads/runs/index.ts
  • src/resources/beta/threads/runs/runs.ts
  • src/resources/beta/threads/threads.ts
  • src/resources/chat/completions/completions.ts
  • src/resources/chat/completions/index.ts
  • src/resources/conversations/index.ts
  • src/resources/embeddings.ts
  • src/resources/files.ts
  • src/resources/fine-tuning/checkpoints/permissions.ts
  • src/resources/images.ts
  • src/resources/responses/internal-base.ts
  • src/resources/responses/responses.ts
  • src/resources/skills/skills.ts
  • src/resources/skills/versions/versions.ts
  • src/resources/vector-stores/file-batches.ts
  • src/resources/vector-stores/files.ts
  • src/resources/webhooks/index.ts
  • src/resources/webhooks/webhooks.ts
  • tests/lib/data-residency.test.ts

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33000604526 --repo openai/openai-node \
  --name castiron-custom-code-33000604526-1 --dir /tmp/castiron-custom-code-33000604526-1
git apply --stat /tmp/castiron-custom-code-33000604526-1/custom-code.patch
cat /tmp/castiron-custom-code-33000604526-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 60f5267509d70e712e960498b64d08cd40969c35 e4e7ed9437c676af792a013e1b4d1a59482a840c
python3 scripts/castiron/custom_code_report.py report \
  --base 60f5267509d70e712e960498b64d08cd40969c35 \
  --head e4e7ed9437c676af792a013e1b4d1a59482a840c --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-e4e7ed9437c6
cat /tmp/castiron-custom-code-e4e7ed9437c6/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all four Standard Schema helper surfaces and independently validated lazy single-read metadata/validator binding, correct validator receiver semantics via Reflect.apply, explicit-schema lazy parsing, reentrant option/metadata getters, unchanged async error handling, and focused regression coverage.

@HAYDEN-OAI
HAYDEN-OAI added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit e4afdb7 Aug 26, 2026
35 checks passed
@HAYDEN-OAI
HAYDEN-OAI deleted the codex/standard-schema-validator-bindings-20260826-mtafo4xu-0khdv4 branch August 26, 2026 19:12
@openai-sdks openai-sdks Bot mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants