Repository navigation
fix(standard-schema): preserve validator bindings across helpers - #2483
HAYDEN-OAI merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 32 mixed files remain; 0 existing customizations changed. Compared 32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33000604526 --repo openai/openai-node \
--name castiron-custom-code-33000604526-1 --dir /tmp/castiron-custom-code-33000604526-1
git apply --stat /tmp/castiron-custom-code-33000604526-1/custom-code.patch
cat /tmp/castiron-custom-code-33000604526-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 60f5267509d70e712e960498b64d08cd40969c35 e4e7ed9437c676af792a013e1b4d1a59482a840c
python3 scripts/castiron/custom_code_report.py report \
--base 60f5267509d70e712e960498b64d08cd40969c35 \
--head e4e7ed9437c676af792a013e1b4d1a59482a840c --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-e4e7ed9437c6
cat /tmp/castiron-custom-code-e4e7ed9437c6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed all four Standard Schema helper surfaces and independently validated lazy single-read metadata/validator binding, correct validator receiver semantics via Reflect.apply, explicit-schema lazy parsing, reentrant option/metadata getters, unchanged async error handling, and focused regression coverage.
Summary
Validation