Skip to content

chore(api): clarify decision creation documentation - #4054

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-229
Oct 11, 2026
Merged

chore(api): clarify decision creation documentation#4054
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-229

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies the input formats and refusal results for decision creation.

Changes

  • Describe text and image inputs, the 128-image limit, and per-question refusal results.

@jbeckwith-oai
chore(api): clarify decision creation documentation
26da120 
Castiron-Internal-PR: openai/openai-python-internal#229
Castiron-Source-SHA: a72d57182d77c7f1e8a8360ba0e5124a36bc75f2
Castiron-Public-Base-SHA: 7352cf5
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 02:58
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 02:58
@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 7352cf5c80cf46b0b7c23634fb7df47c28b0604b.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared 7352cf5c80cf → 26da120cdb9c. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_github.py
  • scripts/castiron/test_custom_code_publication.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38106876710 --repo openai/openai-python \
  --name castiron-custom-code-38106876710-1 --dir /tmp/castiron-custom-code-38106876710-1
git apply --stat /tmp/castiron-custom-code-38106876710-1/custom-code.patch
cat /tmp/castiron-custom-code-38106876710-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 7352cf5c80cf46b0b7c23634fb7df47c28b0604b 26da120cdb9cfaaa35a56809364c5e058acdfedf
python3 scripts/castiron/custom_code_report.py report \
  --base 7352cf5c80cf46b0b7c23634fb7df47c28b0604b \
  --head 26da120cdb9cfaaa35a56809364c5e058acdfedf --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-26da120cdb9c
cat /tmp/castiron-custom-code-26da120cdb9c/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T02:59:19.877210Z 26da120 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T03:00:09.583455Z 26da120 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.229s for Python SDK PR #4054.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 188ms
tests/chat-completions-create.test.ts ✅ Passed 257ms
tests/chat-completions-stream.test.ts ✅ Passed 291ms
tests/files-content-binary.test.ts ✅ Passed 198ms
tests/files-create-multipart.test.ts ✅ Passed 223ms
tests/files-list-pagination.test.ts ✅ Passed 199ms
tests/initialize-config.test.ts ✅ Passed 179ms
tests/instance-isolation.test.ts ✅ Passed 183ms
tests/models-list.test.ts ✅ Passed 277ms
tests/responses-background-lifecycle.test.ts ✅ Passed 230ms
tests/responses-body-method-errors.test.ts ✅ Passed 296ms
tests/responses-cancel-timeout.test.ts ✅ Passed 216ms
tests/responses-cancel.test.ts ✅ Passed 199ms
tests/responses-compact-retries.test.ts ✅ Passed 296ms
tests/responses-compact.test.ts ✅ Passed 308ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 169ms
tests/responses-create-advanced.test.ts ✅ Passed 232ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.227s
tests/responses-create-errors.test.ts ✅ Passed 198ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 548ms
tests/responses-create-retries.test.ts ✅ Passed 245ms
tests/responses-create-stream-failures.test.ts ✅ Passed 233ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 236ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.07s
tests/responses-create-stream.test.ts ✅ Passed 364ms
tests/responses-create-terminal-states.test.ts ✅ Passed 232ms
tests/responses-create-timeout.test.ts ✅ Passed 242ms
tests/responses-create.test.ts ✅ Passed 291ms
tests/responses-delete.test.ts ✅ Passed 189ms
tests/responses-input-items-errors.test.ts ✅ Passed 377ms
tests/responses-input-items-list.test.ts ✅ Passed 313ms
tests/responses-input-items-options.test.ts ✅ Passed 307ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 303ms
tests/responses-input-tokens-count.test.ts ✅ Passed 196ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.108s
tests/responses-not-found-errors.test.ts ✅ Passed 239ms
tests/responses-parse.test.ts ✅ Passed 274ms
tests/responses-retrieve-retries.test.ts ✅ Passed 255ms
tests/responses-retrieve.test.ts ✅ Passed 207ms
tests/responses-stored-method-errors.test.ts ✅ Passed 471ms
tests/retry-behavior.test.ts ✅ Passed 3.181s
tests/sdk-error-shape.test.ts ✅ Passed 308ms

View OkTest run #38106862931

SDK merge (c15ec6b7ba0f) · head (26da120cdb9c) · base (7352cf5c80cf) · OkTest (57341bb8c17e)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26da120cdb9cfaaa35a56809364c5e058acdfedf. No actionable findings.

The full schema changes only the POST /decisions description. The generated documentation agrees with that wording and preserves the existing input restrictions, question order, and refusal semantics. The executable Python AST is unchanged. The change adds no structural complexity.

Reported CI checks and external OkTest passed. Source and static analysis only; I ran no repository tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 16d3d3b Oct 11, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-229 branch October 11, 2026 03:08
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai