Repository navigation
omvg fix - #160
Merged
Merged
omvg fix#160
Conversation
…the docker container
pierotofy
reviewed
Feb 7, 2025
Member
|
Thanks for the fix @eokeeffe ! This can be merged after TBB is dereferenced. For future contributions, build directories shouldn't be added/reverted as a commits, they add a lot of space to the repository. I can squash-merge this PR, but it's sometimes nice to have a finer history of the commit changes. 🙏 |
pierotofy
reviewed
Feb 8, 2025
pierotofy
reviewed
Feb 8, 2025
Member
|
Looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that I hadn't fixed the omvg rotations, openmvg stores col format, needed to fix that for the projections to work
Coming out with more splats now
Took 5000 iterations for this one