Repository navigation
Dismiss thread notifications when opening the thread #18800
Replies: 6 comments 1 reply
|
+1, and I think this should work across environments too, not only inside the mobile app. Example: my laptop and phone are linked through T3 Connect. A thread finishes on the laptop and I get a push notification on my phone. If I then open that thread on the laptop, the notification on the phone should be dismissed as well. So the trigger should be "the thread was opened/read in any connected environment" (mobile, desktop, web), not only navigating to it in the mobile app. Notifications for other unread threads should stay untouched. |
|
I'd like to work on this and open a PR, but CONTRIBUTING asks for maintainer approval of direction and scope first, so here's the proposal: Behavior: when a thread is opened/read in any connected environment (desktop, web, or the mobile app itself), dismiss that thread's "thread completed" push notifications on linked mobile devices. Notifications for other threads stay untouched. Approach (as far as I can tell from the code):
It would also cover the in-app case from the original issue (opening the thread on the phone clears its notification). Questions:
Happy to adjust scope before implementing. |
|
I regularly open T3 from its app icon and read a thread without tapping its completion notification. The old “Done” notifications stay in the shade, so I can end up manually clearing a dozen alerts for work I have already seen. Clearing a thread’s completion alerts when I open it would solve this for me, whether live updates are enabled or not. I find the live card useful while a thread is working, and I would be fine with it going away when the run finishes and a Done alert appears. The important part for me is that the Done alert clears once I open the thread. |
|
@juliusmarminge might want to take a look at this again? #20047 looked good afaict. don't know if theo or you use notifications but it gets cluttered fast without something like this |
|
Same thing on my iPhone. Tapping the notification clears it, but if I open the app from the icon or read the thread on my Mac, the Done alert stays on the lock screen and I end up clearing them by hand for threads I already read. I'd want the cross-device version suggested earlier in the thread too. |
|
I'd like this too. It's very annoying to see a ton of notifications from T3 Code on my phone after a day of active work on my laptop. |
Uh oh!
There was an error while loading. Please reload this page.
Originally filed as issue #17907 by @repparw: #17907
Problem
On mobile, a notification for a thread remains in the notification shade if I open T3 Code and navigate to that thread manually instead of tapping the notification.
This leaves a stale notification for a conversation I've already read.
Expected behavior
When a thread is opened/read in the app, dismiss any system notifications associated with that thread, regardless of whether the thread was opened via the notification itself.
This is similar to WhatsApp: opening a conversation clears its corresponding notification.
Notifications for other unread threads should remain untouched.
Steps to reproduce
Suggested behavior
Associate notifications with their thread/session ID and clear the matching notification(s) when that thread is opened or marked as read.
All reactions