From 3f8d8fee2022d6bb1219e72fa712813a044bc423 Mon Sep 17 00:00:00 2001 From: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Date: Sun, 25 Oct 2026 14:59:12 -0700 Subject: [PATCH] chore(lint): disable returnEffectInGen --- apps/server/src/observability/EventLoopMonitor.ts | 1 - apps/server/src/orchestration-v2/LiveStreamBudget.ts | 1 - apps/server/src/orchestration-v2/ShellStream.ts | 1 - apps/server/src/ws.ts | 1 - infra/relay/src/hooks/HookInboxObject.ts | 1 - tsconfig.base.json | 1 + 6 files changed, 1 insertion(+), 5 deletions(-) diff --git a/apps/server/src/observability/EventLoopMonitor.ts b/apps/server/src/observability/EventLoopMonitor.ts index 377f0148ca6b..32ee54c8b64f 100644 --- a/apps/server/src/observability/EventLoopMonitor.ts +++ b/apps/server/src/observability/EventLoopMonitor.ts @@ -75,7 +75,6 @@ const makeNodeSampler = Effect.gen(function* () { let usage = process.resourceUsage(); let sampledAt = NodePerfHooks.performance.now(); - // @effect-diagnostics-next-line returnEffectInGen:off - the read effect is the result. return Effect.sync(() => { const nextElu = NodePerfHooks.performance.eventLoopUtilization(); const nextUsage = process.resourceUsage(); diff --git a/apps/server/src/orchestration-v2/LiveStreamBudget.ts b/apps/server/src/orchestration-v2/LiveStreamBudget.ts index 39ddf5509a89..f8bdd5de2bf2 100644 --- a/apps/server/src/orchestration-v2/LiveStreamBudget.ts +++ b/apps/server/src/orchestration-v2/LiveStreamBudget.ts @@ -172,7 +172,6 @@ export const makeLiveStreamBudget = Effect.fn("makeLiveStreamBudget")(function* }), Effect.forkScoped, ); - // @effect-diagnostics-next-line returnEffectInGen:off - Stream.fromPull needs the pull effect as its result. return Effect.gen(function* () { // RpcServer requests the next batch after ACK; dequeueing does not end delivery. release(inFlight); diff --git a/apps/server/src/orchestration-v2/ShellStream.ts b/apps/server/src/orchestration-v2/ShellStream.ts index 99ac2b2d89d7..c537465f9c2a 100644 --- a/apps/server/src/orchestration-v2/ShellStream.ts +++ b/apps/server/src/orchestration-v2/ShellStream.ts @@ -384,7 +384,6 @@ export function composeShellStreamWithEnrichment | undefined; // Stream.merge pulls ahead after handing off each batch. Wait for the next // downstream pull so shell delivery keeps that batch charged until its RPC ACK. - // @effect-diagnostics-next-line returnEffectInGen:off - Stream.fromPull needs the pull effect as its result. return Effect.gen(function* () { if (previous) yield* Deferred.succeed(previous, undefined); const next = yield* Queue.take(output); diff --git a/apps/server/src/ws.ts b/apps/server/src/ws.ts index 807527224718..e5696e6f5cd1 100644 --- a/apps/server/src/ws.ts +++ b/apps/server/src/ws.ts @@ -3366,7 +3366,6 @@ export const layer = Layer.unwrap( ), Effect.forkScoped, ); - // @effect-diagnostics-next-line returnEffectInGen:off return httpEffect; }).pipe( Effect.provide( diff --git a/infra/relay/src/hooks/HookInboxObject.ts b/infra/relay/src/hooks/HookInboxObject.ts index c83e74b36e9f..110e119a01e5 100644 --- a/infra/relay/src/hooks/HookInboxObject.ts +++ b/infra/relay/src/hooks/HookInboxObject.ts @@ -75,7 +75,6 @@ export const layer = HookInboxObject.make( Effect.gen(function* () { const state = yield* Cloudflare.DurableObjectState; // Only the per-object inner Effect may access storage. - // @effect-diagnostics-next-line returnEffectInGen:off return Effect.gen(function* () { const layerSql = SqliteClient.layer({ storage: state.raw.storage }); const inboxId = state.raw.id.name ?? state.raw.id.toString(); diff --git a/tsconfig.base.json b/tsconfig.base.json index 8baa38bc3ba1..47fd6ac6e807 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -42,6 +42,7 @@ "flatMapIgnoredParamToAndThen": "error", "mapSomeToAsSome": "error", "unnecessaryPipeChain": "error", + "returnEffectInGen": "off", "effectFnOpportunity": "suggestion", "anyUnknownInErrorContext": "error", "unsafeEffectTypeAssertion": "error",