feat(wasm-rs): codegen should create IModule interface - #1464
Merged
Conversation
Niraj-Kamdar
requested review from
cbrzn,
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
December 24, 2022 16:10
Niraj-Kamdar
marked this pull request as draft
December 24, 2022 16:10
Niraj-Kamdar
force-pushed
the
module-trait-rs
branch
3 times, most recently
from
December 24, 2022 18:24
5bf2b7c to
8acc25c
Compare
Niraj-Kamdar
marked this pull request as ready for review
December 26, 2022 10:58
krisbitney
suggested changes
Dec 27, 2022
krisbitney
left a comment
krisbitney
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I had some super minor comments.
These PRs are a huge improvement. Thanks for doing this!!
Niraj-Kamdar
force-pushed
the
module-trait-rs
branch
from
January 16, 2023 21:28
8acc25c to
d698ea0
Compare
krisbitney
previously approved these changes
Jan 17, 2023
krisbitney
left a comment
krisbitney
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Please fix test before merging
nerfZael
reviewed
Jan 17, 2023
Niraj-Kamdar
force-pushed
the
module-trait-rs
branch
from
February 11, 2023 15:54
d698ea0 to
31de1ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Features