Skip to content

Fix or mitigate https://github.com/python-visualization/folium/issues…#2153

Merged
hansthen merged 1 commit into
python-visualization:mainfrom
sgrefen:is_2152
Jun 3, 2025
Merged

Fix or mitigate https://github.com/python-visualization/folium/issues…#2153
hansthen merged 1 commit into
python-visualization:mainfrom
sgrefen:is_2152

Conversation

@sgrefen

@sgrefen sgrefen commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

…/2152. CustomIcon doesn't exist (anymore?) in leaflet

@hansthen hansthen self-requested a review June 2, 2025 16:41
@hansthen

hansthen commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

I updated the commit slightly. I wanted to make it as a suggestion, but I forgot how to do that. Let me know if you are okay with my change.

@sgrefen sgrefen left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work, it displays the standard Icon instead of the custom one.
image

@hansthen

hansthen commented Jun 3, 2025

Copy link
Copy Markdown
Collaborator

Indeed.

@hansthen hansthen merged commit 68f739f into python-visualization:main Jun 3, 2025
29 checks passed
@hansthen

Copy link
Copy Markdown
Collaborator

@sgrefen Thanks! Your feature is live now.

@sgrefen sgrefen deleted the is_2152 branch June 12, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants