[3.11] Trim trailing whitespace and test on CI (GH-104275)#108215
Merged
Conversation
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk
requested review from
a team,
1st1,
asvetlov,
ezio-melotti and
tiran
as code owners
hugovk
requested review from
AlexWaygood
and removed request for
a team,
1st1,
asvetlov and
tiran
Member
Author
AlexWaygood
reviewed
Aug 22, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
A lot of this diff is removing invisible pagebreak characters. For most of these cases, we should delete the whole line rather than just stripping the "trailing whitespace" from the line:
Member
Member
Author
|
Good idea, and it backported cleanly 🎉 #108266 |
This reverts commit cd547a2.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Reverted Trim trailing whitespace, will update 3.11 into here, and then see what's left to fix. |
Member
Author
|
And autofixed via pre-commit, let's check these changes. |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Member
Author
|
And applied the two suggestions which were still available. |
Member
Author
|
Thank you very much for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.