Skip to content

gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file#117802

Merged
methane merged 4 commits into
python:mainfrom
methane:utf8-pth-file
Apr 16, 2024
Merged

gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file#117802
methane merged 4 commits into
python:mainfrom
methane:utf8-pth-file

Conversation

@methane

@methane methane commented Apr 12, 2024

Copy link
Copy Markdown
Member

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe document the change https://docs.python.org/dev/whatsnew/3.13.html#improved-modules for more visibility.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@methane methane merged commit 6dc661b into python:main Apr 16, 2024
@methane methane deleted the utf8-pth-file branch April 16, 2024 03:56
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.

methane added a commit to methane/cpython that referenced this pull request Apr 16, 2024
…g when reading .pth file (pythonGH-117802)

(cherry picked from commit 6dc661b)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.

@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.

@bedevere-app

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.

methane added a commit that referenced this pull request Apr 16, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants