gh-116738: Make mmap.set_name thread-safe#145555
Merged
Merged
Conversation
Member
|
cc @corona10 |
aisk
commented
Mar 6, 2026
vstinner
approved these changes
Mar 6, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It sounds reasonable to add a critical section to get a consistent view of the memory mapping.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
* Add critical section around mmap.set_name to make it thread-safe * Add news entry * Apply suggestion from @aisk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmap.resizemay update the pointer todataandsize, which is under the protection of a critical section.In
mmap.set_name, it usesdataandsizeto annotate the mmap, but it does not have a critical section around it. So it may use an invaliddataandsizecombination, which may have problems.