Repository navigation
Commit 1d23ba5
fix: skip k8s.io 0.36.0 bump incompatible with controller-runtime v0.23.3 (#11757)
# Description
Dependabot PR #11749 (`3ae32ff7`) bumped `k8s.io/*` from `0.35.4` →
`0.36.0` without bumping `sigs.k8s.io/controller-runtime` past `v0.23.3`
(the latest release). `k8s.io/client-go` v0.36.0 added
`HasSyncedChecker()` to the `ResourceEventHandlerRegistration`
interface, which controller-runtime v0.23.3 doesn't implement — breaking
all 13 CI jobs with:
```
sigs.k8s.io/controller-runtime@v0.23.3/pkg/cache/multi_namespace_cache.go:363:9:
cannot use handles as "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration
(missing method HasSyncedChecker)
```
**Changes:**
- **Apply safe bumps** from the dependabot PR:
`aws-sdk-go-v2/service/ec2` v1.299.0, `smithy-go` v1.25.1,
`fluxcd/source-controller/api` v1.8.3, `terraform-exec` v0.25.1,
`azcore` v1.21.1, `amqp091-go` v1.11.0
- **Keep k8s.io at v0.35.4** — controller-runtime v0.24.x hasn't been
released yet, so the k8s.io minor bump must wait
## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:
- An overview of proposed schema changes is included in a linked GitHub
issue.
- [ ] Yes <!-- TaskRadio schema -->
- [x] Not applicable <!-- TaskRadio schema -->
- A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
- [ ] Yes <!-- TaskRadio design-pr -->
- [x] Not applicable <!-- TaskRadio design-pr -->
- The design document has been reviewed and approved by Radius
maintainers/approvers.
- [ ] Yes <!-- TaskRadio design-review -->
- [x] Not applicable <!-- TaskRadio design-review -->
- A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR.
- [ ] Yes <!-- TaskRadio samples-pr -->
- [x] Not applicable <!-- TaskRadio samples-pr -->
- A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made.
- [ ] Yes <!-- TaskRadio docs-pr -->
- [x] Not applicable <!-- TaskRadio docs-pr -->
- A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR.
- [ ] Yes <!-- TaskRadio recipes-pr -->
- [x] Not applicable <!-- TaskRadio recipes-pr -->
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sylvainsf <540991+sylvainsf@users.noreply.github.com>1 parent 7999b65 commit 1d23ba5
4 files changed
Lines changed: 27 additions & 27 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
310 | | - | |
| 310 | + | |
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments