Skip to content

Commit 1d23ba5

Browse files
Copilotsylvainsf
andauthored
fix: skip k8s.io 0.36.0 bump incompatible with controller-runtime v0.23.3 (#11757)
# Description Dependabot PR #11749 (`3ae32ff7`) bumped `k8s.io/*` from `0.35.4` → `0.36.0` without bumping `sigs.k8s.io/controller-runtime` past `v0.23.3` (the latest release). `k8s.io/client-go` v0.36.0 added `HasSyncedChecker()` to the `ResourceEventHandlerRegistration` interface, which controller-runtime v0.23.3 doesn't implement — breaking all 13 CI jobs with: ``` sigs.k8s.io/controller-runtime@v0.23.3/pkg/cache/multi_namespace_cache.go:363:9: cannot use handles as "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSyncedChecker) ``` **Changes:** - **Apply safe bumps** from the dependabot PR: `aws-sdk-go-v2/service/ec2` v1.299.0, `smithy-go` v1.25.1, `fluxcd/source-controller/api` v1.8.3, `terraform-exec` v0.25.1, `azcore` v1.21.1, `amqp091-go` v1.11.0 - **Keep k8s.io at v0.35.4** — controller-runtime v0.24.x hasn't been released yet, so the k8s.io minor bump must wait ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [x] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes <!-- TaskRadio design-pr --> - [x] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [x] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [x] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [x] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [x] Not applicable <!-- TaskRadio recipes-pr --> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sylvainsf <540991+sylvainsf@users.noreply.github.com>
1 parent 7999b65 commit 1d23ba5

4 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎go.mod‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ require (
2828
github.com/aws/aws-sdk-go-v2/credentials v1.19.15
2929
github.com/aws/aws-sdk-go-v2/service/cloudcontrol v1.29.14
3030
github.com/aws/aws-sdk-go-v2/service/cloudformation v1.71.10
31-
github.com/aws/aws-sdk-go-v2/service/ec2 v1.298.0
31+
github.com/aws/aws-sdk-go-v2/service/ec2 v1.299.0
3232
github.com/aws/aws-sdk-go-v2/service/ecr v1.57.1
3333
github.com/aws/aws-sdk-go-v2/service/sts v1.42.0
34-
github.com/aws/smithy-go v1.25.0
34+
github.com/aws/smithy-go v1.25.1
3535
github.com/charmbracelet/bubbles v1.0.0
3636
github.com/charmbracelet/bubbletea v1.3.10
3737
github.com/charmbracelet/lipgloss v1.1.0
@@ -44,7 +44,7 @@ require (
4444
github.com/fluxcd/pkg/apis/meta v1.26.0
4545
github.com/fluxcd/pkg/http/fetch v0.24.0
4646
github.com/fluxcd/pkg/tar v1.1.0
47-
github.com/fluxcd/source-controller/api v1.8.2
47+
github.com/fluxcd/source-controller/api v1.8.3
4848
github.com/getkin/kin-openapi v0.135.0
4949
github.com/go-chi/chi/v5 v5.2.5
5050
github.com/go-git/go-git/v5 v5.18.0
@@ -70,7 +70,7 @@ require (
7070
github.com/hashicorp/go-retryablehttp v0.7.8
7171
github.com/hashicorp/hc-install v0.9.4
7272
github.com/hashicorp/terraform-config-inspect v0.0.0-20250828155816-225c06ed5fd9
73-
github.com/hashicorp/terraform-exec v0.25.0
73+
github.com/hashicorp/terraform-exec v0.25.1
7474
github.com/hashicorp/terraform-json v0.27.2
7575
github.com/jackc/pgx/v5 v5.9.2
7676
github.com/mattn/go-isatty v0.0.21
@@ -307,7 +307,7 @@ require (
307307
github.com/xanzy/ssh-agent v0.3.3 // indirect
308308
github.com/xlab/treeprint v1.2.0 // indirect
309309
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
310-
github.com/zclconf/go-cty v1.17.0 // indirect
310+
github.com/zclconf/go-cty v1.18.1 // indirect
311311
github.com/zeebo/blake3 v0.2.4 // indirect
312312
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
313313
go.opentelemetry.io/contrib/detectors/gcp v1.39.0 // indirect

‎go.sum‎

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/magpiego/go.mod‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/radius-project/radius/test/magpiego
33
go 1.26.1
44

55
require (
6-
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0
6+
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.1
77
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.1
88
github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus v1.10.0
99
github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets v1.4.0
@@ -13,12 +13,12 @@ require (
1313
github.com/denisenkom/go-mssqldb v0.12.3
1414
github.com/go-chi/chi/v5 v5.2.5
1515
github.com/go-redis/redis/v8 v8.11.5
16-
github.com/rabbitmq/amqp091-go v1.10.0
16+
github.com/rabbitmq/amqp091-go v1.11.0
1717
go.mongodb.org/mongo-driver v1.17.9
1818
)
1919

2020
require (
21-
github.com/Azure/azure-sdk-for-go/sdk/internal v1.11.2 // indirect
21+
github.com/Azure/azure-sdk-for-go/sdk/internal v1.12.0 // indirect
2222
github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/internal v1.2.0 // indirect
2323
github.com/Azure/go-amqp v1.4.0 // indirect
2424
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
@@ -47,7 +47,7 @@ require (
4747
go.opentelemetry.io/otel/metric v1.43.0 // indirect
4848
go.opentelemetry.io/otel/trace v1.43.0 // indirect
4949
golang.org/x/crypto v0.50.0 // indirect
50-
golang.org/x/net v0.52.0 // indirect
50+
golang.org/x/net v0.53.0 // indirect
5151
golang.org/x/sync v0.20.0 // indirect
5252
golang.org/x/sys v0.43.0 // indirect
5353
golang.org/x/text v0.36.0 // indirect

‎test/magpiego/go.sum‎

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)