Handle additionalProperties in resource type display (#11764)

# Description

`rad resource-type show` now displays nested fields for object schemas
defined with `additionalProperties`, so map-style resource properties no
longer render as empty object-property sections.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Fixes: #10257

## Validation

- `go test ./pkg/cli/cmd/resourcetype/show -run
Test_GetResourceTypeSchema_AdditionalProperties -count=1`
- `go test ./pkg/cli/cmd/resourcetype/... -count=1`
- `go vet ./pkg/cli/cmd/resourcetype/...`
- `git diff --check`

## Contributor checklist

- An overview of proposed schema changes is included in a linked GitHub
issue.
    - [ ] Yes <!-- TaskRadio schema -->
    - [x] Not applicable <!-- TaskRadio schema -->
- A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
    - [ ] Yes <!-- TaskRadio design-pr -->
    - [x] Not applicable <!-- TaskRadio design-pr -->
- The design document has been reviewed and approved by Radius
maintainers/approvers.
    - [ ] Yes <!-- TaskRadio design-review -->
    - [x] Not applicable <!-- TaskRadio design-review -->
- A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR.
    - [ ] Yes <!-- TaskRadio samples-pr -->
    - [x] Not applicable <!-- TaskRadio samples-pr -->
- A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made.
    - [ ] Yes <!-- TaskRadio docs-pr -->
    - [x] Not applicable <!-- TaskRadio docs-pr -->
- A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR.
    - [ ] Yes <!-- TaskRadio recipes-pr -->
    - [x] Not applicable <!-- TaskRadio recipes-pr -->

---------

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Co-authored-by: Nithya Subramanian <98416062+nithyatsu@users.noreply.github.com>

Author: AkashKumar7902

pkg/cli/cmd/resourcetype/show/display.go

@@ -211,10 +211,22 @@ func GetResourceTypeSchema(schema map[string]any) map[string]FieldSchema {
 				Description: description,
 				IsRequired:  isRequired,
 				IsReadOnly:  isReadOnly,
-				Properties:  GetResourceTypeSchema(prop),
+				Properties:  GetResourceTypeSchema(getNestedSchema(prop)),
 			}
 		}
 	}
 
 	return fieldSchema
 }
+
+func getNestedSchema(schema map[string]any) map[string]any {
+	if _, ok := schema["properties"].(map[string]any); ok {
+		return schema
+	}
+
+	if additionalProperties, ok := schema["additionalProperties"].(map[string]any); ok {
+		return additionalProperties
+	}
+
+	return schema
+}

pkg/cli/cmd/resourcetype/show/show_test.go

@@ -245,3 +245,162 @@ func Test_Run(t *testing.T) {
 		require.Empty(t, outputSink.Writes)
 	})
 }
+
+func Test_GetResourceTypeSchema_Properties(t *testing.T) {
+	schema := map[string]any{
+		"properties": map[string]any{
+			"name": map[string]any{
+				"type":        "string",
+				"description": "The resource name.",
+			},
+			"settings": map[string]any{
+				"type": "object",
+				"properties": map[string]any{
+					"replicas": map[string]any{
+						"type":        "integer",
+						"description": "Number of replicas.",
+					},
+				},
+				"required": []any{"replicas"},
+			},
+		},
+		"required": []any{"name"},
+	}
+
+	result := GetResourceTypeSchema(schema)
+
+	require.Equal(t, map[string]FieldSchema{
+		"name": {
+			Name:        "name",
+			Type:        "string",
+			Description: "The resource name.",
+			IsRequired:  true,
+			IsReadOnly:  false,
+			Properties:  map[string]FieldSchema{},
+		},
+		"settings": {
+			Name:        "settings",
+			Type:        "object",
+			Description: "",
+			IsRequired:  false,
+			IsReadOnly:  false,
+			Properties: map[string]FieldSchema{
+				"replicas": {
+					Name:        "replicas",
+					Type:        "integer",
+					Description: "Number of replicas.",
+					IsRequired:  true,
+					IsReadOnly:  false,
+					Properties:  map[string]FieldSchema{},
+				},
+			},
+		},
+	}, result)
+}
+
+func Test_getNestedSchema(t *testing.T) {
+	t.Run("returns input when schema has properties", func(t *testing.T) {
+		schema := map[string]any{
+			"properties": map[string]any{
+				"foo": map[string]any{"type": "string"},
+			},
+		}
+
+		got := getNestedSchema(schema)
+		require.Same(t, &schema, &schema)
+		require.Equal(t, schema, got)
+	})
+
+	t.Run("descends into additionalProperties when no properties key", func(t *testing.T) {
+		nested := map[string]any{
+			"properties": map[string]any{
+				"value": map[string]any{"type": "string"},
+			},
+		}
+		schema := map[string]any{
+			"type":                 "object",
+			"additionalProperties": nested,
+		}
+
+		got := getNestedSchema(schema)
+		require.Equal(t, nested, got)
+	})
+
+	t.Run("returns input when neither properties nor additionalProperties match", func(t *testing.T) {
+		schema := map[string]any{
+			"type": "string",
+		}
+
+		got := getNestedSchema(schema)
+		require.Equal(t, schema, got)
+	})
+
+	t.Run("prefers properties over additionalProperties when both exist", func(t *testing.T) {
+		schema := map[string]any{
+			"properties": map[string]any{
+				"a": map[string]any{"type": "string"},
+			},
+			"additionalProperties": map[string]any{
+				"properties": map[string]any{
+					"b": map[string]any{"type": "string"},
+				},
+			},
+		}
+
+		got := getNestedSchema(schema)
+		require.Equal(t, schema, got)
+	})
+}
+
+func Test_GetResourceTypeSchema_AdditionalProperties(t *testing.T) {
+	schema := map[string]any{
+		"properties": map[string]any{
+			"data": map[string]any{
+				"type": "object",
+				"additionalProperties": map[string]any{
+					"type": "object",
+					"properties": map[string]any{
+						"encoding": map[string]any{
+							"type":        "string",
+							"description": "Content encoding of the value.",
+						},
+						"value": map[string]any{
+							"type":        "string",
+							"description": "The secret value.",
+						},
+					},
+				},
+			},
+		},
+	}
+
+	result := GetResourceTypeSchema(schema)
+
+	require.Equal(t, map[string]FieldSchema{
+		"data": {
+			Name:        "data",
+			Type:        "object",
+			Description: "",
+			IsRequired:  false,
+			IsReadOnly:  false,
+			Properties: map[string]FieldSchema{
+				"encoding": {
+					Name:        "encoding",
+					Type:        "string",
+					Description: "Content encoding of the value.",
+					IsRequired:  false,
+					IsReadOnly:  false,
+					Properties:  map[string]FieldSchema{},
+				},
+				"value": {
+					Name:        "value",
+					Type:        "string",
+					Description: "The secret value.",
+					IsRequired:  false,
+					IsReadOnly:  false,
+					Properties:  map[string]FieldSchema{},
+				},
+			},
+		},
+	}, result)
+}