fix k-fold-cv helper functions#96
Merged
Merged
Conversation
jgabry
requested changes
Jan 3, 2019
jgabry
left a comment
Member
There was a problem hiding this comment.
I'm glad you're making all these PRs! I think there are a few tiny things to change but otherwise this looks good.
The tests in tests/test_kfold_helpers.R also need to be fixed and the NEWS file updated, but I can take care of those things if you want.
Member
Author
|
Sorry for making a pull request with broken code. I modified tests, too, as I need to learn to use tests. |
[ci skip]
[ci skip]
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #49 (comment)
kfold_split_stratified