Skip to content

fix k-fold-cv helper functions#96

Merged
jgabry merged 6 commits into
masterfrom
fix-kfold-helper-49
Jan 4, 2019
Merged

fix k-fold-cv helper functions#96
jgabry merged 6 commits into
masterfrom
fix-kfold-helper-49

Conversation

@avehtari

@avehtari avehtari commented Jan 3, 2019

Copy link
Copy Markdown
Member

As mentioned in #49 (comment)

@avehtari avehtari requested a review from jgabry January 3, 2019 17:48

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you're making all these PRs! I think there are a few tiny things to change but otherwise this looks good.

The tests in tests/test_kfold_helpers.R also need to be fixed and the NEWS file updated, but I can take care of those things if you want.

Comment thread R/kfold-helpers.R
Comment thread R/kfold-helpers.R Outdated
Comment thread R/kfold-helpers.R Outdated
@avehtari

avehtari commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

Sorry for making a pull request with broken code. I modified tests, too, as I need to learn to use tests.

@jgabry jgabry merged commit 2d7f108 into master Jan 4, 2019
@jgabry jgabry deleted the fix-kfold-helper-49 branch January 4, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants