Repository navigation
[6.x] Fix duplicate burger ARIA id and empty-state heading order - #15572
Merged
Merged
Conversation
Make the nav toggle icon decorative so inlined SVGs no longer share a title id, and nest EmptyState headings as h2/h3 under the page h1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Two CP accessibility issues from #15409:
burger-menu-no-border.svg) had a hardcodedtitleid referenced byaria-labelledby. Because the icon is inlined in two places in the header, the page emitted duplicate ARIA ids (duplicate-id-aria).<h1>to item<h3>s with no<h2>, which axe flags asheading-order(dashboard empty state, collections, taxonomies, navigation, fieldsets, roles, groups, etc.).What this PR Does
aria-hidden="true") and removes the title / labelledby / role markup. The toggle button already has its own accessible name viaaria-label.EmptyStateMenuheading is anh2(via a newCardPanellevelprop), andEmptyStateItemheadings default toh3(overridable with alevelprop).h2→h3hierarchy.Visual appearance is unchanged (heading styles come from
size, not the tag; burger paths are identical).Fixes #15409
How to Reproduce
6.x, open/cp/playground(or any CP page) and run:document.querySelectorAll('#burger-menu-title').length→> 1/cp/rolesor/cp/fieldsetswith no items) and run:[...document.querySelectorAll('h1,h2,h3')].map(h => h.tagName)→H1thenH3s0H1,H2(menu), thenH3s (items)