Repository navigation
[6.x] Fix is_homepage when trailing slashes are enforced - #15613
Merged
jasonvarga merged 1 commit intoOct 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15612.
With
URL::enforceTrailingSlashes()enabled,Site::absoluteUrl()keeps its trailing slash (http://test.com/), while Laravel'sRequest::url()never has one (http://test.com). The cascade compares the two directly, sois_homepageis nevertrue.This removes the trailing slash from the site URL before comparing. Without enforced trailing slashes the site URL has no trailing slash to begin with, so nothing changes there. A site in a subdirectory (
http://test.com/de/) is handled the same way.Adds tests for a homepage and a non-homepage request with trailing slashes enforced.