Repository navigation
[6.x] Stop parallel Stache warming losing cached index usages - #15736
Merged
jasonvarga merged 2 commits intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With parallel warming enabled,
_indexesunderstorage/framework/cache/data/stache/indexeschanges from onestache:warmto the next.Store::cacheIndexUsage()overwrites the cache key with its in-memory list, so when two warm processes touch the same store, the last writer drops the other's usages.Fix: merge with the cached list before writing, and sort it so the file is byte-stable. Repeated parallel warms with the
processandforkdrivers now produce identical caches.Closes #13261