From a0534ad0d59026837f4cb44e3afa81296eada43c Mon Sep 17 00:00:00 2001 From: "Philipp M. Fischer" Date: Tue, 16 Jan 2018 17:03:53 +0100 Subject: [PATCH] GitlabAPI.getNotes(...) call creating non api v4 compliant URL (#283) - Fixed both methods to extract correct IID rather than the ID to access the Notes from an GitlabIssue --- src/main/java/org/gitlab/api/GitlabAPI.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/gitlab/api/GitlabAPI.java b/src/main/java/org/gitlab/api/GitlabAPI.java index a9806d23..f42e8335 100644 --- a/src/main/java/org/gitlab/api/GitlabAPI.java +++ b/src/main/java/org/gitlab/api/GitlabAPI.java @@ -1982,14 +1982,14 @@ private void applyIssue(GitlabHTTPRequestor requestor, int projectId, public GitlabNote getNote(GitlabIssue issue, Integer noteId) throws IOException { String tailUrl = GitlabProject.URL + "/" + issue.getProjectId() + - GitlabIssue.URL + "/" + issue.getId() + + GitlabIssue.URL + "/" + issue.getIid() + GitlabNote.URL + "/" + noteId; return retrieve().to(tailUrl, GitlabNote.class); } public List getNotes(GitlabIssue issue) throws IOException { String tailUrl = GitlabProject.URL + "/" + issue.getProjectId() + GitlabIssue.URL + "/" - + issue.getId() + GitlabNote.URL; + + issue.getIid() + GitlabNote.URL; return Arrays.asList(retrieve().to(tailUrl, GitlabNote[].class)); }