From 7e71a01157d796aca26a76ccf70699f9fef9c945 Mon Sep 17 00:00:00 2001
From: vastsa <hhxk666@gmail.com>
Date: Wed, 23 Sep 2026 04:00:20 +0800
Subject: [PATCH 1/2] fix(chat): show why a vendor session cannot launch

A launch failure before any message is stored left an error-only assistant
row that the empty home treated as no transcript, so the chat page went
blank. Keep that row visible, and name a vendor-account model the account
list did not return.
---
 apps/desktop/src/components/ChatSurface.tsx  | 65 ++++++++++++++------
 apps/desktop/src/lib/chat-launch-error.ts    | 49 +++++++++++++++
 apps/desktop/test/chat-launch-error.test.mjs | 59 ++++++++++++++++++
 3 files changed, 155 insertions(+), 18 deletions(-)
 create mode 100644 apps/desktop/src/lib/chat-launch-error.ts
 create mode 100644 apps/desktop/test/chat-launch-error.test.mjs

diff --git a/apps/desktop/src/components/ChatSurface.tsx b/apps/desktop/src/components/ChatSurface.tsx
index 70b3e293e5..92ef4476ab 100644
--- a/apps/desktop/src/components/ChatSurface.tsx
+++ b/apps/desktop/src/components/ChatSurface.tsx
@@ -1,5 +1,9 @@
-import { memo, useMemo } from "react";
+import { memo, useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
+import {
+  messageHasTranscriptContent,
+  vendorAccountOmitsSessionModel,
+} from "../lib/chat-launch-error";
 import { Composer } from "./Composer";
 import { HomeMascotLogo } from "./HomeMascotLogo";
 import { HomeProjectSwitcher } from "./HomeProjectSwitcher";
@@ -53,6 +57,10 @@ export const ChatSurface = memo(function ChatSurface() {
   const error = useAppStore((state) => state.error);
   const errorCode = useAppStore((state) => state.errorCode);
   const errorRetriable = useAppStore((state) => state.errorRetriable);
+  const [hiddenVendorModelKey, setHiddenVendorModelKey] = useState<string | null>(
+    null,
+  );
+  const providers = useAppStore((state) => state.providers);
   const activeSession = useAppStore((state) =>
     state.activeSessionId
       ? state.sessions.find((session) => session.id === state.activeSessionId)
@@ -107,19 +115,28 @@ export const ChatSurface = memo(function ChatSurface() {
   const hasTranscript =
     Boolean(activePermission) ||
     askPending ||
-    messages.some((message) => {
-      const hasContent = Boolean((message.content || "").trim());
-      const hasThinking =
-        typeof message.thinking === "string" &&
-        Boolean(message.thinking.trim());
-      if (message.role === "assistant") return hasContent || hasThinking;
-      return hasContent || message.role === "tool";
-    });
+    messages.some((message) => messageHasTranscriptContent(message));
   // The empty state belongs to the session on screen. While a cold switch is
   // still resolving, the visible pane keeps its own transcript, so the hero must
   // not take over just because the destination projection is still empty.
   const showEmptyState =
     !hasTranscript && (!visibleSessionId || visibleSessionId === activeSessionId);
+  const vendorModelMissing = vendorAccountOmitsSessionModel(
+    activeSession,
+    providers,
+  );
+  const vendorModelKey = vendorModelMissing
+    ? `${activeSession?.providerId ?? ""}:${activeSession?.modelId ?? ""}`
+    : null;
+  const showVendorModelError =
+    vendorModelKey !== null && hiddenVendorModelKey !== vendorModelKey;
+  const noticeError =
+    error ?? (showVendorModelError ? t("errors.MODEL_NOT_CONFIGURED") : null);
+  const noticeCode = error
+    ? errorCode
+    : showVendorModelError
+      ? "MODEL_NOT_CONFIGURED"
+      : null;
   return (
     <div
       className={`chat-surface route-surface${sessionSwitching ? " session-switching" : ""}`}
@@ -185,17 +202,23 @@ export const ChatSurface = memo(function ChatSurface() {
         </>
       )}
 
-      {error ? (
+      {noticeError ? (
         <div className="chat-error-layer">
           <div className="chat-error-notice">
-            <span title={error ?? undefined}>
-              {errorCode && i18nHasError(t, errorCode)
-                ? t(`errors.${errorCode}`)
-                : error}
+            <span title={noticeError}>
+              {noticeCode && i18nHasError(t, noticeCode)
+                ? t(`errors.${noticeCode}`)
+                : noticeError}
+              {showVendorModelError && !error && activeSession?.modelId ? (
+                <>
+                  {" "}
+                  <code>{activeSession.modelId}</code>
+                </>
+              ) : null}
             </span>
-            {(errorCode === "MODEL_NOT_CONFIGURED" ||
-              errorCode === "PROVIDER_SECRET_MISSING" ||
-              errorCode === "PROVIDER_UNAUTHORIZED") && (
+            {(noticeCode === "MODEL_NOT_CONFIGURED" ||
+              noticeCode === "PROVIDER_SECRET_MISSING" ||
+              noticeCode === "PROVIDER_UNAUTHORIZED") && (
               <button
                 type="button"
                 className="chat-error-action"
@@ -224,7 +247,13 @@ export const ChatSurface = memo(function ChatSurface() {
               tooltip={t("errors.action.dismiss")}
               ariaLabel={t("errors.action.dismiss")}
               className="chat-error-dismiss"
-              onClick={() => useAppStore.getState().clearError()}
+              onClick={() => {
+                if (error) {
+                  useAppStore.getState().clearError();
+                  return;
+                }
+                if (vendorModelKey) setHiddenVendorModelKey(vendorModelKey);
+              }}
             >
               <IconX size={13} />
             </TooltipButton>
diff --git a/apps/desktop/src/lib/chat-launch-error.ts b/apps/desktop/src/lib/chat-launch-error.ts
new file mode 100644
index 0000000000..2803554ca1
--- /dev/null
+++ b/apps/desktop/src/lib/chat-launch-error.ts
@@ -0,0 +1,49 @@
+import { modelIdsMatch, OAUTH_AUTH_KIND } from "@pi-desktop/shared";
+
+type TranscriptMessage = {
+  role: string;
+  content?: string;
+  thinking?: string;
+  error?: unknown;
+};
+
+/** An assistant row that only carries a launch error is still the conversation. */
+export function messageHasTranscriptContent(message: TranscriptMessage): boolean {
+  const hasContent = Boolean((message.content || "").trim());
+  const hasThinking =
+    typeof message.thinking === "string" && Boolean(message.thinking.trim());
+  if (message.role === "assistant") {
+    return hasContent || hasThinking || Boolean(message.error);
+  }
+  return hasContent || message.role === "tool";
+}
+
+type VendorSessionModel = {
+  providerId?: string | null;
+  modelId?: string | null;
+};
+
+type VendorModelProvider = {
+  id: string;
+  authKind?: string;
+  models?: ReadonlyArray<{ id: string }>;
+};
+
+/**
+ * Vendor accounts refuse a session model the account list did not return.
+ * An empty list means the catalog has not loaded, not that the account
+ * offers nothing, so it must not turn a normal empty chat into an error.
+ */
+export function vendorAccountOmitsSessionModel(
+  session: VendorSessionModel | null | undefined,
+  providers: readonly VendorModelProvider[],
+): boolean {
+  const providerId = session?.providerId?.trim();
+  const modelId = session?.modelId?.trim();
+  if (!providerId || !modelId) return false;
+  const provider = providers.find((item) => item.id === providerId);
+  if (!provider || provider.authKind !== OAUTH_AUTH_KIND) return false;
+  const models = provider.models ?? [];
+  if (models.length === 0) return false;
+  return !models.some((model) => modelIdsMatch(model.id, modelId));
+}
diff --git a/apps/desktop/test/chat-launch-error.test.mjs b/apps/desktop/test/chat-launch-error.test.mjs
new file mode 100644
index 0000000000..008fe1f046
--- /dev/null
+++ b/apps/desktop/test/chat-launch-error.test.mjs
@@ -0,0 +1,59 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import {
+  messageHasTranscriptContent,
+  vendorAccountOmitsSessionModel,
+} from "../src/lib/chat-launch-error.ts";
+
+const oauth = (models) => [{ id: "chatgpt", authKind: "oauth", models }];
+
+test("a launch error with no assistant text still counts as a transcript", () => {
+  assert.equal(
+    messageHasTranscriptContent({
+      role: "assistant",
+      content: "",
+      error: { code: "MODEL_NOT_CONFIGURED", message: "missing" },
+    }),
+    true,
+  );
+  assert.equal(
+    messageHasTranscriptContent({ role: "assistant", content: "   " }),
+    false,
+  );
+  assert.equal(
+    messageHasTranscriptContent({ role: "user", content: "hello" }),
+    true,
+  );
+});
+
+test("an empty vendor chat names a model the account did not return", () => {
+  const session = { providerId: "chatgpt", modelId: "gpt-6-luna" };
+  assert.equal(
+    vendorAccountOmitsSessionModel(session, oauth([{ id: "gpt-5.6-luna" }])),
+    true,
+  );
+  assert.equal(
+    vendorAccountOmitsSessionModel(session, oauth([{ id: "openai/gpt-6-luna" }])),
+    false,
+  );
+  assert.equal(vendorAccountOmitsSessionModel(session, oauth([])), false);
+  assert.equal(
+    vendorAccountOmitsSessionModel(session, [
+      { id: "chatgpt", authKind: "api_key", models: [{ id: "gpt-5.6-luna" }] },
+    ]),
+    false,
+  );
+});
+
+test("the chat surface shows that omission instead of an empty page", async () => {
+  const { readFile } = await import("node:fs/promises");
+  const surface = await readFile(
+    new URL("../src/components/ChatSurface.tsx", import.meta.url),
+    "utf8",
+  );
+  assert.match(surface, /messageHasTranscriptContent\(message\)/);
+  assert.match(surface, /vendorAccountOmitsSessionModel\(/);
+  assert.match(surface, /activeSession\.modelId/);
+  assert.match(surface, /noticeError \?/);
+});

From ad3018498957a49335b698eee606e0c482d549b7 Mon Sep 17 00:00:00 2001
From: vastsa <hhxk666@gmail.com>
Date: Wed, 23 Sep 2026 04:08:51 +0800
Subject: [PATCH 2/2] test(chat): follow the extracted transcript visibility
 check

The thinking-only empty-home guard moved into chat-launch-error.ts.
Point the source contract at that helper and at the ChatSurface call.
---
 apps/desktop/test/thinking-ui.test.mjs | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/apps/desktop/test/thinking-ui.test.mjs b/apps/desktop/test/thinking-ui.test.mjs
index bc38087b41..6bfd0e27ca 100644
--- a/apps/desktop/test/thinking-ui.test.mjs
+++ b/apps/desktop/test/thinking-ui.test.mjs
@@ -29,6 +29,10 @@ const appSource = await readFile(
   new URL("../src/components/ChatSurface.tsx", import.meta.url),
   "utf8",
 );
+const launchErrorSource = await readFile(
+  new URL("../src/lib/chat-launch-error.ts", import.meta.url),
+  "utf8",
+);
 const providerCatalogSource = await readMainModule("runtime/provider-catalog.ts");
 const sessionIpcSource = await readMainModule("ipc/session-ipc.ts");
 const sessionLaunchSource = await readMainModule("runtime/session-launch.ts");
@@ -285,8 +289,9 @@ test("activity headers omit the redundant status capsule", () => {
 });
 
 test("thinking-only assistant streams open the transcript surface", () => {
-  assert.match(appSource, /typeof message\.thinking === "string"/);
-  assert.match(appSource, /hasContent \|\| hasThinking/);
+  assert.match(launchErrorSource, /typeof message\.thinking === "string"/);
+  assert.match(launchErrorSource, /hasContent \|\| hasThinking/);
+  assert.match(appSource, /messageHasTranscriptContent\(message\)/);
 });
 
 test("provider settings persist model-local limits and thinking configuration", () => {