fix: bind process in case global is overwritten (#11343)

Author: AriPerkkio

packages/vitest/src/runtime/moduleRunner/cachedResolver.ts

@@ -4,6 +4,7 @@ import { splitFileAndPostfix } from '@vitest/utils/helpers'
 import { join, normalize } from 'pathe'
 import { distDir } from '../../paths'
 
+const platform = process.platform
 const bareVitestRegexp = /^@?vitest(?:\/|$)/
 const normalizedDistDir = normalize(distDir)
 const relativeIds: Record<string, string> = {}
@@ -23,7 +24,7 @@ export function getCachedVitestImport(
   state: () => WorkerGlobalState,
 ): null | { externalize: string; type: 'module' } {
   if (id.startsWith('/@fs/') || id.startsWith('\\@fs\\')) {
-    id = id.slice(process.platform === 'win32' ? 5 : 4)
+    id = id.slice(platform === 'win32' ? 5 : 4)
   }
 
   if (externalizeMap.has(id)) {

packages/vitest/src/runtime/rpc.ts

@@ -8,6 +8,8 @@ import { getWorkerState } from './utils'
 
 const { get } = Reflect
 
+const globalProcess = globalThis.process
+
 function withSafeTimers(fn: () => void) {
   const { setTimeout, clearTimeout, nextTick, setImmediate, clearImmediate }
     = getSafeTimers()
@@ -17,7 +19,7 @@ function withSafeTimers(fn: () => void) {
   const currentSetImmediate = globalThis.setImmediate
   const currentClearImmediate = globalThis.clearImmediate
 
-  const currentNextTick = globalThis.process?.nextTick
+  const currentNextTick = globalProcess?.nextTick
 
   try {
     globalThis.setTimeout = setTimeout
@@ -30,8 +32,8 @@ function withSafeTimers(fn: () => void) {
       globalThis.clearImmediate = clearImmediate
     }
 
-    if (globalThis.process && nextTick) {
-      globalThis.process.nextTick = nextTick
+    if (globalProcess && nextTick) {
+      globalProcess.nextTick = nextTick
     }
 
     const result = fn()
@@ -43,9 +45,9 @@ function withSafeTimers(fn: () => void) {
     globalThis.setImmediate = currentSetImmediate
     globalThis.clearImmediate = currentClearImmediate
 
-    if (globalThis.process && nextTick) {
+    if (globalProcess && nextTick) {
       nextTick(() => {
-        globalThis.process.nextTick = currentNextTick
+        globalProcess.nextTick = currentNextTick
       })
     }
   }

test/unit/test/stubbed-process.test.ts

@@ -1,17 +1,41 @@
-import { expect, it, vi } from 'vitest'
+import { beforeAll, describe, expect, it, onTestFinished, vi } from 'vitest'
 
-vi.stubGlobal('process', { badMock: true })
+describe('undefined process', () => {
+  // This has to be first test of the file to trigger rpc withSafeTimers race
+  it('undefined process when importing file outside root', async () => {
+    const realProcess = globalThis.process
 
-it('should not hang', () => {
-  expect(1).toBe(1)
-})
+    onTestFinished(async () => {
+      globalThis.process = realProcess
+    })
+
+    globalThis.process = undefined as any
 
-it('should not crash (#9173)', async () => {
-  await import('./fixtures/increment')
+    const mod = await import('../../test-utils/fixtures/external-math')
+    expect(mod.sum(2, 3)).toBe(5)
+  })
 })
 
-it('should not hang', () => {
-  vi.unstubAllGlobals()
+describe('stubbed process', () => {
+  beforeAll(() => {
+    vi.stubGlobal('process', { badMock: true })
+
+    return () => {
+      vi.unstubAllGlobals()
+    }
+  })
+
+  it('should not hang', () => {
+    expect(1).toBe(1)
+  })
+
+  it('should not crash (#9173)', async () => {
+    await import('./fixtures/increment')
+  })
+
+  it('should not hang', () => {
+    vi.unstubAllGlobals()
 
-  process.stdout.write = () => true
+    process.stdout.write = () => true
+  })
 })