fix(expect): fix toMatchObject with asymmetric matchers (#11100)

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Co-authored-by: Hiroshi Ogawa <4232207+hi-ogawa@users.noreply.github.com>
Co-authored-by: Codex <noreply@openai.com>

Author: 4 people

packages/expect/src/jest-utils.ts

@@ -77,12 +77,15 @@ function asymmetricMatch(a: any, b: any, customTesters: Array<Tester>) {
     return undefined
   }
 
+  // Asymmetric matchers define their own subset semantics.
+  const testers = customTesters.filter(tester => !isSubsetEqualityTester(tester))
+
   if (asymmetricA) {
-    return a.asymmetricMatch(b, customTesters)
+    return a.asymmetricMatch(b, testers)
   }
 
   if (asymmetricB) {
-    return b.asymmetricMatch(a, customTesters)
+    return b.asymmetricMatch(a, testers)
   }
 }
 
@@ -604,6 +607,20 @@ function isObjectWithKeys(a: any) {
   )
 }
 
+// Recursive subset testers are closures, so track them by identity.
+const subsetEqualityTesters = new WeakSet<Tester>()
+
+function registerSubsetEqualityTester<T extends Tester>(
+  tester: T,
+): T {
+  subsetEqualityTesters.add(tester)
+  return tester
+}
+
+function isSubsetEqualityTester(tester: Tester): boolean {
+  return tester === subsetEquality || subsetEqualityTesters.has(tester)
+}
+
 export function subsetEquality(
   object: unknown,
   subset: unknown,
@@ -617,7 +634,7 @@ export function subsetEquality(
   // there are circular references in the subset passed to it.
   const subsetEqualityWithContext
     = (seenReferences: WeakMap<object, boolean> = new WeakMap()) =>
-      (object: any, subset: any): boolean | undefined => {
+      registerSubsetEqualityTester((object: any, subset: any): boolean | undefined => {
         if (!isObjectWithKeys(subset)) {
           return undefined
         }
@@ -645,7 +662,7 @@ export function subsetEquality(
           seenReferences.delete(subset[key])
           return result
         })
-      }
+      })
 
   return subsetEqualityWithContext()(object, subset)
 }

test/unit/test/jest-expect.test.ts

@@ -226,6 +226,33 @@ describe('jest-expect', () => {
     )
   })
 
+  // https://github.com/vitest-dev/vitest/issues/11071
+  it('asymmetric matchers and toMatchObject equality', () => {
+    expect([{ id: 1 }]).not.toMatchObject(
+      expect.arrayContaining([{ id: 1, required: 'x' }]),
+    )
+    expect({ nested: [{ id: 1 }] }).not.toMatchObject({
+      nested: expect.arrayContaining([{ id: 1, required: 'x' }]),
+    })
+    expect({ nested: [{ id: 1, extra: true }] }).not.toMatchObject({
+      nested: expect.arrayContaining([{ id: 1 }]),
+    })
+    expect({ nested: [{ id: 1 }] }).not.toMatchObject({
+      nested: expect.arrayContaining([{ id: 1 }]),
+      extra: true,
+    })
+
+    expect({ nested: [{ id: 1, required: 'x' }] }).toMatchObject({
+      nested: expect.arrayContaining([{ id: 1, required: 'x' }]),
+    })
+    expect({ nested: [{ id: 1, required: 'x' }, { extra: true }] }).toMatchObject({
+      nested: expect.arrayContaining([{ id: 1, required: 'x' }]),
+    })
+    expect({ nested: [{ id: 1 }], extra: true }).toMatchObject({
+      nested: expect.arrayContaining([{ id: 1 }]),
+    })
+  })
+
   it('asymmetric matchers negate', () => {
     expect('bar').toEqual(expect.not.stringContaining('zoo'))
     expect('bar').toEqual(expect.not.stringMatching(/zoo/))