Skip to content

feat(emulation): update emulation device enums from wreq-util rc.10#516

Merged
0x676e67 merged 1 commit into
0x676e67:mainfrom
steppaovo:emulation-upgrades
Feb 12, 2026
Merged

feat(emulation): update emulation device enums from wreq-util rc.10#516
0x676e67 merged 1 commit into
0x676e67:mainfrom
steppaovo:emulation-upgrades

Conversation

@steppaovo

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @steppaovo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the wreq-util dependency to its latest release candidate and expands the available browser emulation options. It introduces support for newer versions of Chrome, Edge, and Firefox, ensuring the system can accurately mimic a broader range of user agents. This update helps maintain compatibility and provides more current emulation capabilities.

Highlights

  • Dependency Update: The wreq-util dependency has been updated from version 3.0.0-rc.9 to 3.0.0-rc.10 in Cargo.toml.
  • New Chrome Emulation Versions: Added Chrome144 and Chrome145 to the Emulation enum in both the Python and Rust emulation modules.
  • New Edge Emulation Versions: Added Edge143, Edge144, and Edge145 to the Emulation enum in both the Python and Rust emulation modules.
  • New Firefox Emulation Version: Added Firefox147 to the Emulation enum in both the Python and Rust emulation modules.
Changelog
  • Cargo.toml
    • Updated wreq-util dependency to version 3.0.0-rc.10.
  • python/rnet/emulation.py
    • Added Chrome144 and Chrome145 to the Emulation enum.
    • Added Edge143, Edge144, and Edge145 to the Emulation enum.
    • Added Firefox147 to the Emulation enum.
  • src/emulation.rs
    • Added Chrome144 and Chrome145 to the define_enum! macro.
    • Added Edge143, Edge144, and Edge145 to the define_enum! macro.
    • Added Firefox147 to the define_enum! macro.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the wreq-util dependency to version 3.0.0-rc.10 and correspondingly expands the available browser emulation options. New enum members for recent versions of Chrome, Edge, and Firefox have been added to both the Rust core and the Python bindings, ensuring consistency. The changes are straightforward and correct. I have one suggestion regarding the long-term maintainability of the emulation enums to prevent potential synchronization issues between the Rust and Python codebases.

Comment thread src/emulation.rs
Comment on lines +43 to +44
Chrome144,
Chrome145,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These enums are manually synchronized with python/rnet/emulation.py. As this list of emulations grows, there's an increasing risk of the definitions in the two files becoming out of sync. To improve long-term maintainability and prevent potential runtime errors, consider using a single source of truth. For example, a data file (like YAML or JSON) could define the emulations, and build scripts could generate both the Rust and Python enum definitions from it.

@0x676e67
0x676e67 merged commit eb25f00 into 0x676e67:main Feb 12, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants