feat(emulation): update emulation device enums from wreq-util rc.10#516
Conversation
Summary of ChangesHello @steppaovo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the wreq-util dependency to version 3.0.0-rc.10 and correspondingly expands the available browser emulation options. New enum members for recent versions of Chrome, Edge, and Firefox have been added to both the Rust core and the Python bindings, ensuring consistency. The changes are straightforward and correct. I have one suggestion regarding the long-term maintainability of the emulation enums to prevent potential synchronization issues between the Rust and Python codebases.
| Chrome144, | ||
| Chrome145, |
There was a problem hiding this comment.
These enums are manually synchronized with python/rnet/emulation.py. As this list of emulations grows, there's an increasing risk of the definitions in the two files becoming out of sync. To improve long-term maintainability and prevent potential runtime errors, consider using a single source of truth. For example, a data file (like YAML or JSON) could define the emulations, and build scripts could generate both the Rust and Python enum definitions from it.
No description provided.