Skip to content

HRX: pin llama.cpp 96f6b89, fixing #95 (GLM-4.7-Flash, Qwen3-Coder at full context) - #104

Merged
bong-water-water-bong merged 2 commits into
mainfrom
hrx/bump-95
Sep 25, 2026
Merged

bong-water-water-bong merged 2 commits into
mainfrom
hrx/bump-95

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

Fixes #95. Supersedes #101 and #103: their commits are in this pin, plus the fix that #103 needed.

Pin. third_party/llama.cpp moves c075cc1 -> 96f6b89 (1bit-MONSTER/llama.cpp#4, merged into 1bit/hrx-vulkan-patched):

Engine. Removes #97's 32768 context default for --device hrx: HRX0 now keeps flash attention at a model's full context.

Verified on Strix Halo, fresh build of this branch (-DONEBIT_HRX=ON):

  • tools/registry_check.py --only hrx: 7 of 7 pass at full context. That covers Qwen3-0.6B, Qwen2.5-7B, Qwen3-Coder-30B-A3B, Qwen3.6-35B-A3B Q8_0, GLM-4.7-Flash, MiniCPM4-8B and MiniCPM5-1B.
  • serve_e2e ... vulkan --prefill-device hrx passes.
  • test-backend-ops -b HRX0: 790/790.

Docs: registry.md, PORTING and serve.md are updated, and registry/checked.json has the new HRX rows.

🤖 Generated with Claude Code

bong-water-water-bong and others added 2 commits September 25, 2026 20:22
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… docs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bong-water-water-bong
bong-water-water-bong enabled auto-merge (squash) September 25, 2026 23:38
@context7

context7 Bot commented Sep 25, 2026

Copy link
Copy Markdown

Docs7 for 1bit-monster/engine

Result Status Action
Deployment ➖ Not used —
Content review ➖ Did not run. This site has no agent runs available this month. Wait for the monthly reset or check your Docs7 plan. —

Commit 855a543

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

95 - Partially compliant

Compliant requirements:

  • Fix HTTP 500 "Compute error." when running Qwen3-Coder-30B-A3B-Instruct Q4_K_M and GLM-4.7-Flash on HRX
  • Ensure MoE models can run at full context (262144 tokens) on HRX
  • Resolve issues with non-FA attention path for MoE models
  • Fix flash attention claims for MLA and full-context MoE shapes

Non-compliant requirements:

  • None

Requires further human verification:

  • Verification that the fixes work as expected on actual hardware (Strix Halo)
  • Confirmation that the batched MoE routing bug is fully resolved (GLM-4.7-Flash answer correctness)
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Context Size Default Change

The default context size for --device hrx has been changed from 32768 to allow full context. This change removes the limitation that caused flash attention to be disabled at full context for MoE models, which was the root cause of the 500 "Compute error." This is a functional change that impacts how models are served on HRX.

if (o.ctx_size > 0) { argv.push_back("-c"); argv.push_back(std::to_string(o.ctx_size)); }
Registry Update

The registry documentation has been updated to reflect that GLM-4.7-Flash and Qwen3-Coder-30B-A3B now pass on HRX after the llama.cpp pin. This is a documentation update that correctly reflects the state of the system after the fix.

GLM-4.7-Flash and Qwen3-Coder-30B-A3B failed on HRX until the llama.cpp pin `96f6b89` (#95).
The pin fixes four things:
- HRX0 now claims flash attention for MLA heads (576) and at full context (262144).
- The path without flash attention now compiles.
- HRX0 no longer claims a sigmoid MoE router.
- HRX0's expert matmul (MUL_MAT_ID) now reads each token's expert ids at their real row
  stride. It used to read them packed, so every token of a batched prompt after the first
  went to the wrong experts. Qwen MoE models were immune, because their router dispatch
  supplies the stride.

@bong-water-water-bong
bong-water-water-bong merged commit 36e2eef into main Sep 25, 2026
5 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the hrx/bump-95 branch September 25, 2026 23:40
bong-water-water-bong pushed a commit that referenced this pull request Sep 26, 2026
…ama.cpp #2, #5)

The pin adds the zaya architecture and its converter on top of 96f6b89 (#104's #95 fixes).
registry/architectures.json, regenerated: ZayaForCausalLM maps to hrx and vulkan
(266 architectures, all mapped).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong pushed a commit that referenced this pull request Sep 26, 2026
…ama.cpp #2, #5, #6)

The pin adds the zaya architecture and its converter (#2, #5) on top of #104's #95 fixes, and
carries #106's scalar-scatter SET_ROWS onto the tracked branch (#6): #106 pinned c358334,
which is on no branch of the fork. registry/architectures.json, regenerated:
ZayaForCausalLM maps to hrx and vulkan (266 architectures, all mapped).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong added a commit that referenced this pull request Sep 26, 2026
…nly architectures (#107)

* ZAYA1 (Zyphra) on Vulkan: serve routes fork-only architectures to our llama.cpp

`1bit serve --device vulkan` reads the GGUF's general.architecture (app/gguf_meta.h) and
runs an architecture only our llama.cpp implements (zaya) on the HRX build's Vulkan0, even
when the upstream Vulkan build is present. registry_build counts such architectures for
vulkan the same way, and check_models.tsv checks ZAYA1-8B Q4_K_M on vulkan.

docs/vulkan.md: converting and serving ZAYA1, with the checks against transformers and
the measured speeds on Strix Halo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ZAYA1 on HRX and ROCm: docs, and serve_e2e on vulkan and hrx in the registry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Pin llama.cpp 5556bf2: ZAYA1 on Vulkan, HRX and ROCm (1bit-MONSTER/llama.cpp #2, #5, #6)

The pin adds the zaya architecture and its converter (#2, #5) on top of #104's #95 fixes, and
carries #106's scalar-scatter SET_ROWS onto the tracked branch (#6): #106 pinned c358334,
which is on no branch of the fork. registry/architectures.json, regenerated:
ZayaForCausalLM maps to hrx and vulkan (266 architectures, all mapped).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* registry: vulkan and hrx rows re-checked at b9812e0 (16/16 pass, ZAYA1-8B included)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: build gguf_meta_test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HRX: chat on Qwen3-Coder-30B-A3B and GLM-4.7-Flash fails with 500 "Compute error."

1 participant