Repository navigation
Bump HRX: llama.cpp 0d3ed9e3ff21 + hrx-system 82804197bcbe - #458
Merged
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit 57a1160)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 57a1160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the HRX submodules along our line. AMD's tested pair (ROCm/ggml-staging-automation) is llama.cpp
dbe1d6e1a27e+ hrx-system61c152ac4b40; the workflow merges it into our branches (a conflict fails the run and names the files).8d9ce2c1aa600d3ed9e3ff2182804197bcbe82804197bcbehrx-system HELD at
82804197bcbebyconfig/hrx-system-hold.config(AMD's tested pin is61c152ac4b40).llama.cpp commits new to the engine:
0d3ed9e3fqwen: make rmsnorm q8 publication consumer-driven again (engine HRX: restore consumer-driven activation publication (dropped whole in f2099e9b) #449) (HRX: dense on HRX0 with experts on another device fails for Qwen MoE models (fused router) #108)c26c071a0tests: retire the HRX: symmetric-i4 consumer route re-enabled by AMD aadd6025 after f2099e9b removed it #450 known-fail guard, the symmetric-i4 route is not a regression (engine HRX: symmetric-i4 consumer route re-enabled by AMD aadd6025 after f2099e9b removed it #450) (ONNX on the GPU on Linux: ONNX Runtime's WebGPU provider (ONNX_WEBGPU=1) #109)29dd88200qwen: publish the next-RMSNorm q8 alternate from the fused routed-down kernel (engine HRX: restore consumer-driven activation publication (dropped whole in f2099e9b) #449) (ZAYA1 (Zyphra) on the GPU: pin llama.cpp 5556bf2, serve routes fork-only architectures #107)953b6397btests: retire the HRX: restore consumer-driven activation publication (dropped whole in f2099e9b) #449 guard for gdn rmsnorm-gate publication (engine HRX: restore consumer-driven activation publication (dropped whole in f2099e9b) #449) (hrx: scalar-scatter SET_ROWS for the non-FA path (-fa off) (#95) #106)7227a7711tests: per-case runner and the hrx-backend-test: 49 host cases red after the AMD-core re-head — classification (stale expectation vs needs a ruling) #445 ACCEPT rows (registry: causes of the two ZINC failures (Qwen2.5-7B load crash, MiniCPM5 empty reply) #105)8dafc4a05tests: build the HRX tests against the ggml-hrx we ship (engine#422) (HRX: pin llama.cpp 96f6b89, fixing #95 (GLM-4.7-Flash, Qwen3-Coder at full context) #104)CI here builds without HRX. Before merging, on Strix Halo run the long-prompt correctness
probe and
test-backend-ops -b HRX0; record the exact validated hrx-system pin inconfig/hrx-long-prompt-validated-pin.config:python3 tests/hrx_long_prompt.pycmake -B build -G Ninja -DONEBIT_HRX=ON && cmake --build build --target onebit && for d in hrx cpu; do tests/serve_e2e.sh build/1bit <Qwen3-0.6B Q4_K_M .gguf> $d; done