Repository navigation
Bump ZINC: zolotukhin/zinc 29bc350ac4cb - #132
Merged
Merged
Conversation
|
Docs7 for 1bit-monster/engine
Commit |
PR Reviewer Guide 🔍(Review updated until commit 6eb4ca0)Here are some key observations to aid the review process:
|
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
…; name the failing step (#135) Found by a dry-run rehearsal: the suite expects a lemond already listening (port 13305) and needs numpy from test/requirements.txt, so the Lemonade bump was held for the wrong reason, and the held reason quoted the (passing) ctest log. Now lemond from the build runs on its own port for the suite; a held bump names the step and the log that failed. First-release notes say "commit" for a new pin and drop "None →". Rehearsal on Strix Halo (WEEKLY_DRY_RUN=1): #132 (ZINC) and #133 (Lemonade) pass; Lemonade's LLM suite through onebit on Vulkan: Ran 31 tests, OK (skipped=2). Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
…n the model rows (#136) - pins_on_branch, before the build: every pin a PR moves must be on the branch .gitmodules names for that submodule (GitHub compare: identical or ahead). Twice this week an engine PR pinned a fork commit on no branch (#103, #106); the shallow clones follow the branch and could not have fetched it. - bump-hrx/* and bump-llama-vulkan/*: every hrx / vulkan row of registry/check_models.tsv through registry_check (serve end to end per architecture: ZAYA1, the Qwen MoE models, GLM, MiniCPM), under the memory guard; any FAIL holds the bump. Build + ctest alone serve one small GGUF, which would not notice an architecture breaking. Tested pins_on_branch against the open PRs: #121's llama.cpp pin f59f6d37 fails (diverged from 1bit/hrx-vulkan-patched); the ZINC (#132) and Lemonade (#133) pins pass. Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong
enabled auto-merge (squash)
September 26, 2026 18:38
|
Persistent review updated to latest commit 6eb4ca0 |
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
… registry counts current (#162) * Site: this week's milestones post; OPT/GPT-Neo/CodeGen/GPT-J in docs; registry counts current - blog: Zyphra's whole family (74B, legacy base models, ZAYA1-VL, Zamba*), four older architectures, MoE experts from the drive, deterministic HRX decode, ONNX on the GPU; every number from a committed doc. - docs/vulkan.md: the four older architectures from our llama.cpp (#138), with their FP32 agreement. - docs/registry.md: counts at the current pins (323 mapped; was 265), and what mapped means. - registry: regenerated for ZINC 29bc350 (#132); counts unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * registry: regenerate for llama.cpp-vulkan 546800c (#161) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
…ws regenerate it (#165) registry_build.py --check-pins compares the pins registry/architectures.json records with the committed gitlinks (no checkouts). scripts/registry-regen.sh fetches the three trees at their pins, regenerates and amends; bump-zinc, bump-llama-vulkan and bump-hrx run it after committing a pin. #132 and #161 moved pins without it. RFC: discussion #164. Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
bong-water-water-bong
pushed a commit
that referenced
this pull request
Oct 23, 2026
…ons) Fork #132 (tests only): require_matmul_route() accepts the table's kernel or the registered kquant decode family and prints the scheduled sequence when neither is there; stale decode/prefill sibling names and three routed-MoE names replaced from the first device run's log (engine #444). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves third_party/zinc from
3a35e76d64ebto upstream main29bc350ac4cb.Upstream commits (last 30):
CI here has no GPU. Before merging, on Strix Halo:
scripts/build-zinc.sh ~/.cache/zinc-pin vulkan && RADV_PERFTEST=coop_matrix ~/.cache/zinc-pin/vulkan/bin/zinc -m ~/models/Qwen3-0.6B-Q4_K_M.gguf --prompt 'The capital of France is'(first token 12095).