Repository navigation
Bump Lemonade: 1bit-MONSTER/lemonade 2b491610b828 - #133
Merged
Merged
Conversation
|
Docs7 for 1bit-monster/engine
Commit |
PR Reviewer Guide 🔍(Review updated until commit 63e3665)Here are some key observations to aid the review process:
|
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
…; name the failing step (#135) Found by a dry-run rehearsal: the suite expects a lemond already listening (port 13305) and needs numpy from test/requirements.txt, so the Lemonade bump was held for the wrong reason, and the held reason quoted the (passing) ctest log. Now lemond from the build runs on its own port for the suite; a held bump names the step and the log that failed. First-release notes say "commit" for a new pin and drop "None →". Rehearsal on Strix Halo (WEEKLY_DRY_RUN=1): #132 (ZINC) and #133 (Lemonade) pass; Lemonade's LLM suite through onebit on Vulkan: Ran 31 tests, OK (skipped=2). Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Persistent review updated to latest commit 63e3665 |
Collaborator
Author
|
Verified on Strix Halo (Sunday-run rehearsal, |
bong-water-water-bong
added a commit
that referenced
this pull request
Sep 26, 2026
…n the model rows (#136) - pins_on_branch, before the build: every pin a PR moves must be on the branch .gitmodules names for that submodule (GitHub compare: identical or ahead). Twice this week an engine PR pinned a fork commit on no branch (#103, #106); the shallow clones follow the branch and could not have fetched it. - bump-hrx/* and bump-llama-vulkan/*: every hrx / vulkan row of registry/check_models.tsv through registry_check (serve end to end per architecture: ZAYA1, the Qwen MoE models, GLM, MiniCPM), under the memory guard; any FAIL holds the bump. Build + ctest alone serve one small GGUF, which would not notice an architecture breaking. Tested pins_on_branch against the open PRs: #121's llama.cpp pin f59f6d37 fails (diverged from 1bit/hrx-vulkan-patched); the ZINC (#132) and Lemonade (#133) pins pass. Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves third_party/lemonade from
fb65f488457fto the fork's main2b491610b828.Fork commits (last 30):
CI here has no GPU. Before merging, on Strix Halo:
scripts/build-lemonade.sh ~/.cache/lemonade-pin, then Lemonade's LLM suite through the onebit recipe (docs/lemonade.md).