Skip to content

Bump HRX: llama.cpp 0e255d774032 (NVFP4, Q2_0 decode lanes; IQ3_S/IQ4_NL GET_ROWS on HRX; fork #98-#100) - #373

Merged
bong-water-water-bong merged 1 commit into
mainfrom
bump-hrx/0e255d774032-98d05d94a9f9
Oct 9, 2026
Merged

bong-water-water-bong merged 1 commit into
mainfrom
bump-hrx/0e255d774032-98d05d94a9f9

Conversation

@bong-water-water-bong

Copy link
Copy Markdown
Collaborator

Moves third_party/llama.cpp e44c9d01a4d5 -> 0e255d774032 (fork tip after #98, #99 via #100, #100). third_party/hrx-system stays at 98d05d94: 4ba76c18 returns end-of-text on long prompts (#369). Registry regenerated (hrx 292, npu 7, mapped 292; tools/registry_build.py --check-pins clean).

Verified on strixhalo (performance mode, HRX0 visible via IREE_HAL_AMDGPU_LIBHSA_PATH, every GPU step under box.lock; logs ~/wt/pinverify-0e255d7/):

CI here builds without HRX; the above is the Strix Halo gate from docs/hrx.md.

🤖 Generated with Claude Code

…_NL GET_ROWS on HRX; fork #98-#100)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

98 - Partially compliant

Compliant requirements:

  • Add docs/arch-gaps.md with evidence for eleven HF architecture classes
  • Add registry/significant.json with the eleven classes
  • Add tools/registry_build.py --check-gaps functionality
  • Update docs/registry.md to link the gap review page

Non-compliant requirements:

  • The alias table and its 100% coverage claim were not included (as noted in the ticket description)

Requires further human verification:

  • Verification that the gap review is accurate and complete

99 - Partially compliant

Compliant requirements:

  • Cross-build engine for Windows 10+ x64 on Linux
  • Produce two static executables: 1bit.exe and llama-server.exe
  • 1bit.exe finds llama-server.exe beside it
  • Use CreateProcess with kill-on-close job object for backend processes
  • Use Winsock for free_port and std::signal for signals
  • Maintain POSIX paths unchanged
  • Build with Windows 10 API level for cpp-httplib
  • Static linking with MinGW
  • Fetch pinned inputs with sha256 checks

Non-compliant requirements:

  • Not yet tested on a real Windows machine

Requires further human verification:

  • Testing on a real Windows machine

100 - Partially compliant

Compliant requirements:

  • Support ONNX Runtime GenAI models via 1bit serve --device onnx
  • Use third_party/ryzenai-server as the backend server
  • Build ryzenai-server against ONNX Runtime GenAI 0.11.2 and ONNX Runtime 1.23.2
  • Support CPU execution with optional Ryzen AI Software for NPU/hybrid
  • Include proper NOTICE file entries
  • Ensure binary carries DT_RPATH $ORIGIN for runtime dlopen

Non-compliant requirements:

  • ryzenai-server.exe in scripts/build-windows.sh not yet implemented (mentioned as next step)

Requires further human verification:

  • Verification of ONNX backend functionality on target hardware
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Subproject Update

The subproject commit for llama.cpp has been updated from e44c9d01a4d5110cecaf45472a717f46cd1abbf9 to 0e255d774032dc6b4b06a157d2feb6be2175d3ab. This update includes changes from forks #98 through #100, which may introduce new functionality or behavior changes that should be verified for compatibility and correctness.

Subproject commit 0e255d774032dc6b4b06a157d2feb6be2175d3ab
Registry Source Update

The registry source for llama.cpp (hrx) has been updated to reflect the new commit hash. This change aligns the registry with the updated llama.cpp version, ensuring that the architecture mappings are consistent with the latest codebase changes.

"llama.cpp (hrx)": "0e255d774032dc6b4b06a157d2feb6be2175d3ab"

@bong-water-water-bong
bong-water-water-bong merged commit 06049db into main Oct 9, 2026
7 checks passed
@bong-water-water-bong
bong-water-water-bong deleted the bump-hrx/0e255d774032-98d05d94a9f9 branch October 9, 2026 13:56
bong-water-water-bong pushed a commit that referenced this pull request Oct 9, 2026
… long-prompt result

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bong-water-water-bong added a commit that referenced this pull request Oct 9, 2026
…a76c18 long-prompt result (#364)

* docs: note the engine#315 pin movement in KNOWN-ISSUES.md

The entry cites 26330cc20490 as the pin engine@main ships; main now pins
e44c9d01a4d5 with hrx-system 98d05d94 (#361 reverted in #363). The study's
measurements still describe what ships: 98d05d94 is the same runtime, and
26330cc20490 is an ancestor of e44c9d01a4d5.

* docs: the engine#315 pin note covers #373 and the hrx-system 4ba76c18 long-prompt result

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: bong-water-water-bong <bong-water-water-bong@users.noreply.github.com>
Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant